Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary -keep rule for AndroidDispatcherFactory, AndroidEx… #3263

Merged
merged 2 commits into from May 18, 2022
Merged

Remove unnecessary -keep rule for AndroidDispatcherFactory, AndroidEx… #3263

merged 2 commits into from May 18, 2022

Commits on May 17, 2022

  1. Remove unnecessary -keep rule for AndroidDispatcherFactory, AndroidEx… 

    …ceptionPreHandler

R8 supports keeping and/or optimizing classes found in
META-INF/services:
https://b.corp.google.com/issues/120436373#comment7

The last R8 commit I can find related to ServerLoader is
https://r8-review.googlesource.com/53824 (Sept 2020),
so I think R8 1.6 still needs the -keep rule, but 3.0+ should not.

Fixes: 3111
    @agrieve
    agrieve committed May 17, 2022
    Copy the full SHA
    6ececff View commit details
    Browse the repository at this point in the history

Commits on May 18, 2022

  1. Update the comments in proguard files to reflect the new structure

    @dkhalanskyjb
    dkhalanskyjb committed May 18, 2022
    Copy the full SHA
    0c8d842 View commit details
    Browse the repository at this point in the history