Do not load a CoroutineExceptionHandler SL eagerly on Android as it c… #3190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please also take a look @yorickhenning? |
|
Perhaps instead of special-casing by platform using an I have a functioning workaround for #2552, and 0b65246 didn't make that workaround unnecessary. To me specifically, 0b65246 and this patch are no-ops, because I've bypassed the This patch reintroduces the problem described in #2552 on Android, and makes the library more complicated. I'll add some notes to #2552. |
dkhalanskyjb
approved these changes
Feb 16, 2022
kotlinx-coroutines-core/jvm/src/CoroutineExceptionHandlerImpl.kt
Outdated
Show resolved
Hide resolved
qwwdfsad
force-pushed
the
fix-disk-read-violation
branch
from
f2a41d4
to
a6ec3f2
Compare
dkhalanskyjb
approved these changes
Feb 16, 2022
dee-tree
pushed a commit
to dee-tree/kotlinx.coroutines
that referenced
this pull request
Jul 21, 2022
… service (Kotlin#2957)" (Kotlin#3190) This reverts commit 0b65246.
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
… service (Kotlin#2957)" (Kotlin#3190) This reverts commit 0b65246.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…auses verification of the whole JAR/dex (-> file I/O) and ANR
Fixes #3180