CoroutineDispatcher.asScheduler for the Rx modules #3150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please squash all of I find it really hard to navigate, especially now with incorrect GH rendering where all changes seems to be contributed by you: |
qwwdfsad
requested changes
Jan 24, 2022
dkhalanskyjb
force-pushed
the
pull-1923
branch
from
9e00911
to
a13d99e
Compare
dkhalanskyjb
force-pushed
the
pull-1923
branch
from
33667be
to
e43a152
Compare
|
Kover finds non-covered code in two places:
|
qwwdfsad
approved these changes
Feb 17, 2022
| schedulerJob.cancel() | ||
| } | ||
|
|
||
| private class DispatcherWorker(val counter: Long, val dispatcher: CoroutineDispatcher, parentJob: Job) : Worker() { |
There was a problem hiding this comment.
[super optional] typically private can save a getter and a setter
| Runnable { scope.launch { task() } } | ||
| } | ||
|
|
||
| private val workerCounter = atomic(1L) |
There was a problem hiding this comment.
[code style] it would be nice to both have a line indent here and to keep both properties and functions grouped separately, not mixing them all over the place
Also, * Don't use `kotlinx-coroutines-test` * Now shutting down the scheduler will interrupt the tasks
The test never did reliably pass, and it doesn't seem like there's anything in the Scheduler docs that mandates this behavior.
Remove cruft and ensure that they do actually fail if the tasks are not disposed of.
dkhalanskyjb
force-pushed
the
pull-1923
branch
from
45cbda6
to
e79d8de
Compare
|
Merged manually to preserve authorship: d5f852c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1923
Fixes #968
Fixes #548
Authored by @recheej