Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback #2972, but leave a compatibility option with 1.6.0 #3131

Merged
merged 1 commit into from Jan 17, 2022

Commits on Jan 11, 2022

  1. Rollback #2972, but leave a compatibility option with 1.6.0

    The approach from 1.6.0 has proven itself as unstable and multiple hard-to-understand bugs have been reported:
    
    * JavaFx timer doesn't really work outside the main thread
    * The frequent initialization pattern "runBlocking { doSomethingThatMayCallDelay() }" used on the main thread during startup now silently deadlocks
    * The latter issue was reported both by Android and internal JB Compose users
    * The provided workaround with system property completely switches off the desired behaviour that e.g. Compose may rely on, potentially introducing new sources of invalid behaviour
    
    The original benefits does not outweigh these pitfalls, so the decision is to revert this changes in the minor release
    
    Fixes #3113
    Fixes #3106
    qwwdfsad committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    7436025 View commit details
    Browse the repository at this point in the history