Eagerly load CoroutineExceptionHandler and load corresponding service #2957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially addresses #2552
| @@ -22,6 +22,12 @@ private val handlers: List<CoroutineExceptionHandler> = ServiceLoader.load( | |||
| CoroutineExceptionHandler::class.java.classLoader | |||
| ).iterator().asSequence().toList() | |||
|
|
|||
| internal actual fun initializeDefaultExceptionHandlers() { | |||
| // Load CEH and handlers | |||
| CoroutineExceptionHandler | |||
There was a problem hiding this comment.
I'd expect Class.forName or something here instead. As is, could you please explain due to what guarantees does this not get thrown away as dead code?
There was a problem hiding this comment.
JVM has no right to throw away any code with side effects. Classloading is not pure, GETSTATIC CEH.Key will trigger classloading:
https://docs.oracle.com/javase/specs/jvms/se7/html/jvms-5.html#jvms-5.4.3
Also, the key here is to initialize handlers which are initialized when initializeDefaultExceptionHandlers first accessed (because these symbols belong to the same class)
dkhalanskyjb
approved these changes
Oct 12, 2021
yorickhenning
pushed a commit
to yorickhenning/kotlinx.coroutines
that referenced
this pull request
Oct 14, 2021
…Kotlin#2957) * Eagerly load CoroutineExceptionHandler and load the corresponding service Partially addresses Kotlin#2552
dee-tree
pushed a commit
to dee-tree/kotlinx.coroutines
that referenced
this pull request
Jul 21, 2022
… service (Kotlin#2957)" (Kotlin#3190) This reverts commit 0b65246.
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
…Kotlin#2957) * Eagerly load CoroutineExceptionHandler and load the corresponding service Partially addresses Kotlin#2552
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
… service (Kotlin#2957)" (Kotlin#3190) This reverts commit 0b65246.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #2552