Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce coroutines platform to have all the dependencies aligned #2952

Merged
merged 2 commits into from Oct 20, 2021
Merged

Introduce coroutines platform to have all the dependencies aligned #2952

merged 2 commits into from Oct 20, 2021

Conversation

qwwdfsad
Copy link
Member

Fixes #2865

@qwwdfsad
Copy link
Member Author

qwwdfsad commented Sep 24, 2021 •
edited

Unfortunately, it cannot be built (=> merged) prior to 1.6.0: unless JetBrains/kotlin@0cd29ad is released, kotlin-compiler-embeddable depends on kotlinx-coroutines-core, and after dependency alignment, in order to build
kotlinx-coroutines-core of our x-SNAPSHOT version we have to first resolve kotlin-compiler-embeddable dependency to the very same version, making a dependency cycle.

It's still possible to test it locally though: first one has to do publishToMavenLocal the original project, then add mavenLocal to the list of repositories, apply the proposed patch and then publishToMavenLocal.
Then I've verified the problem in #2865 is gone

@qwwdfsad
Copy link
Member Author

Verified it works on 1.6.0-RC-512

@qwwdfsad qwwdfsad requested review from dkhalanskyjb and removed request for dkhalanskyjb October 12, 2021 17:03
@qwwdfsad qwwdfsad merged commit e6592c4 into develop Oct 20, 2021
yorickhenning pushed a commit to yorickhenning/kotlinx.coroutines that referenced this pull request Jan 28, 2022
@qwwdfsad @yorickhenning
Introduce coroutines platform to have all the dependencies aligned (K…
eb9a33c 
…otlin#2952)

* Introduce coroutines platform to have all the dependencies aligned

Fixes Kotlin#2865
@qwwdfsad qwwdfsad mentioned this pull request May 16, 2022
Closed
pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this pull request Sep 14, 2022
@qwwdfsad @pablobaxter
Introduce coroutines platform to have all the dependencies aligned (K…
7b5b3ee 
…otlin#2952)

* Introduce coroutines platform to have all the dependencies aligned

Fixes Kotlin#2865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhalanskyjb dkhalanskyjb dkhalanskyjb approved these changes

Assignees
No one assigned
Labels
For 1.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qwwdfsad @dkhalanskyjb