Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make helpRemove actually lock-free and address multiple chained remov… #2795

Merged
merged 1 commit into from Jul 27, 2021
Merged

Make helpRemove actually lock-free and address multiple chained remov… #2795

merged 1 commit into from Jul 27, 2021

Conversation

qwwdfsad
Copy link
Member

…ed nodes

* The previous version invoked correctPrev on the next node and bailed out fi it was removed, effectively blocking the progress of any attempts to remove previous node
* Use helpRemovePrev in helpRemove that was actually implemented to avoid such problem

Fixes #2590

@qwwdfsad
Make helpRemove actually lock-free and address multiple chained remov…
32057ee 
…ed nodes

    * The previous version invoked correctPrev on the next node and bailed out fi it was removed, effectively blocking the progress of any attempts to remove previous node
    * Use helpRemovePrev in helpRemove that was actually implemented to avoid such problem

Fixes #2590
@qwwdfsad qwwdfsad requested a review from elizarov June 29, 2021 13:56
elizarov
elizarov approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Amazing discovery!

@qwwdfsad qwwdfsad merged commit ea440c5 into develop Jul 27, 2021
@qwwdfsad qwwdfsad deleted the mutex-lock-freedom branch July 27, 2021 17:30
pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this pull request Sep 14, 2022
@qwwdfsad @pablobaxter
Make helpRemove actually lock-free and address multiple chained remov…
fca1fd4 
…ed nodes (Kotlin#2795)

* The previous version invoked correctPrev on the next node and bailed out fi it was removed, effectively blocking the progress of any attempts to remove previous node
    * Use helpRemovePrev in helpRemove that was actually implemented to avoid such problem

Fixes Kotlin#2590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizarov elizarov elizarov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qwwdfsad @elizarov