Prevent StackOverflowError in CompletableFuture.asDeferred and proper… #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly report exceptions from completion handlers
* It turned out that 'cancel' on completed future tries to help and invoke 'whenComplete' handlers that also invoke 'cancel' on the very same future
* Use top-level exception handler as a last resort to deliver an exception
Fixes #2730
dkhalanskyjb
approved these changes
May 27, 2021
| class FutureAsDeferredUnhandledCompletionExceptionTest : TestBase() { | ||
|
|
||
| // This is a separate test in order to avoid interference with uncaught exception handlers in other tests | ||
| private val exceptionHandler = Thread.getDefaultUncaughtExceptionHandler() |
There was a problem hiding this comment.
Minor: wouldn't it be more symmetrical if exceptionHandler was also initialized in setUp?
There was a problem hiding this comment.
I find it more concise to initialize in-place everything that could be initialized in-place, [opinionated] it reads better and is easier to reason about
integration/kotlinx-coroutines-guava/test/FutureAsDeferredUnhandledCompletionExceptionTest.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
Kotlin#2731) Prevent StackOverflowError in CompletableFuture.asDeferred and properly report exceptions from completion handlers * It turned out that 'cancel' on completed future tries to help and invoke 'whenComplete' handlers that also invoke 'cancel' on the very same future * Use top-level exception handler as a last resort to deliver an exception Fixes Kotlin#2730
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ly report exceptions from completion handlers
Fixes #2730