Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove platform-specific dependencies on JavaFx artifacts #2369

Merged
merged 2 commits into from Nov 26, 2020

Conversation

elizarov
Copy link
Contributor

@elizarov elizarov commented Nov 5, 2020

Fixes #2360

@elizarov elizarov requested review from qwwdfsad and dkhalanskyjb and removed request for qwwdfsad November 5, 2020 13:42
Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the way the plugin version is increased, everything looks good.

@@ -3,13 +3,20 @@
*/

plugins {
id("org.openjfx.javafxplugin")
id("org.openjfx.javafxplugin") version "0.0.9"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be done by changing javafx_plugin_version in gradle.properties instead?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it seems that changing the version does nothing to fix the issue: the problem is solved by just making the edit to configuration below.

I'm making this comment just for documentation purposes.

test.configure {
compileClasspath += configurations.compileOnly
runtimeClasspath += configurations.compileOnly
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking through options provided by the JavaFX plugin, I don't see a better way to do this. Looking at discussions where other projects face the same problem (openjfx/javafx-gradle-plugin#85, https://stackoverflow.com/questions/60249348/run-gradle-tests-using-image-from-badass-runtime-plugin and some others), it seems that the community didn't yet find a clean solution either.

@qwwdfsad qwwdfsad merged commit 0e5aefd into develop Nov 26, 2020
@qwwdfsad qwwdfsad deleted the javafx-deps branch November 26, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants