Repair some corner cases in cancellation propagation between coroutines and listenable futures #2222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es and listenable futures Implement bidirectional cancellation for `future` coroutine builder. This also: * Refactors JobListenableFuture infrastructure so it can be reused in CoroutineScope.future and Deferred.asListenableFuture; * Provides more descriptive `toString` implementation for the returned Future; * Fixes stack traces in thrown exception, so it includes call to get() that triggered the exception to be thrown; * Hides ListenableFuture.asDeferred return type, so it can't be casted to CompletableDeferred; * Adds more tests to cover fixed corner cases; * Improves documentation; * Suppresses annoying warnings in tests.
|
Fixes #1442 |
|
Ping? |
qwwdfsad
requested changes
Nov 16, 2020
* Replace `Result` with `Cancelled` to save an allocation on successful completion. * Add a test to show that `CancellationException` is never passed to `CoroutineExceptionHandler`. * Explicitly specify return types. * Use @JvmField on "package-private" property to not generate an accessor.
vadimsemenov
commented
Nov 25, 2020
qwwdfsad
approved these changes
Nov 25, 2020
Also fix indentation.
|
Done. |
qwwdfsad
approved these changes
Nov 26, 2020
This was referenced Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement bidirectional cancellation for
futurecoroutine builder.This also:
toStringimplementation for the returned Future;