Properly check identity of caught AbortFlowException in Flow.first op… #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizarov
suggested changes
May 25, 2020
…erator.
It fixes two problems:
* NoSuchElementException can be thrown during cancellation sequence (see FirstJvmTest that reproduces this problem with explanation)
* Cancellation can be accidentally suppressed and flow activity can be prolonged
Fixes #2051
qwwdfsad
force-pushed
the
first-suppressed-afe
branch
from
85d38b0
to
245f9b6
Compare
elizarov
approved these changes
May 25, 2020
There was a problem hiding this comment.
It is great, but there is a lot of copy-paste between different terminal operators in this code. Now their source is hard to read. I suggest to introduce new (experimental) terminal operator collectWhile that will contain all the "abort exception magic" and rewrite all size-limited operators from the firstXxx family using collectWhile, keeping their source easy to read.
elizarov
reviewed
May 27, 2020
recheej
pushed a commit
to recheej/kotlinx.coroutines
that referenced
this pull request
Dec 28, 2020
Kotlin#2057) It fixes two problems: * NoSuchElementException can be thrown during cancellation sequence (see FirstJvmTest that reproduces this problem with explanation) * Cancellation can be accidentally suppressed and flow activity can be prolonged Fixes Kotlin#2051
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erator.
It fixes two problems:
* NoSuchElementException can be thrown during cancellation sequence (see FirstJvmTest that reproduces this problem with explanation)
* Cancellation can be accidentally suppressed and flow activity can be prolonged
Fixes #2051