Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking: Get rid of atomic cancellation and provide a replacement #1937

Merged
merged 46 commits into from Oct 12, 2020
Merged

Breaking: Get rid of atomic cancellation and provide a replacement #1937

merged 46 commits into from Oct 12, 2020

Commits on Sep 16, 2020

  1. Refactoring: Improve DispatchedTask.run a bit

    @elizarov
    elizarov committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    074ea3d View commit details
    Browse the repository at this point in the history

  2. Remove atomic cancellation support 

    This is a problematic for Android when Main dispatcher is cancelled on destroyed activity.
Atomic nature of channels is designed to prevent loss of elements,
which is really not an issue for a typical application, but creates problem when used with channels.

* Internal suspendAtomicCancellableCoroutine -> suspendCancellableCoroutine
* Internal suspendAtomicCancellableCoroutineReusable -> suspendCancellableCoroutineReusable
* Remove atomic cancellation from docs
* Ensures that flowOn does not resume downstream after cancellation.
* MODE_ATOMIC_DEFAULT renamed into MODE_ATOMIC
* Introduced MODE_CANCELLABLE_REUSABLE to track suspendCancellableCoroutineReusable
* Better documentation for MODE_XXX constants.
* Added stress test for proper handling of MODE_CANCELLABLE_REUSABLE
  and fixed test for #1123 bug with job.join (working in MODE_CANCELLABLE) that was not
  properly failing in the absence of the proper code in CancellableContinuationImpl.getResult
* Added test for Flow.combine that should be fixed
* Support extended invokeOnCancellation contract
* Introduced internal tryResumeAtomic

Fixes #1265
Fixes #1813
Fixes #1915
    @elizarov
    elizarov committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    e68cb3b View commit details
    Browse the repository at this point in the history

  3. Basic resource transfer support (WIP)

    @elizarov
    elizarov committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    46238a6 View commit details
    Browse the repository at this point in the history

  4. ~ Refactor to Channel.onElementCancel lambda 

    Fixes #1936
    @elizarov
    elizarov committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    5281798 View commit details
    Browse the repository at this point in the history

  5. ~ onElementCancel docs

    @elizarov
    elizarov committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    3228b92 View commit details
    Browse the repository at this point in the history

  6. ~ Fixup kotlinx-coroutines-rx3 module to internal API changes

    @elizarov
    elizarov committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    340e411 View commit details
    Browse the repository at this point in the history

  7. ~ Fixup new Semaphore implementation for non-atomic resume

    @elizarov
    elizarov committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    5e1ecd8 View commit details
    Browse the repository at this point in the history

  8. ~ ChannelOnCancellationFailureTest

    @elizarov
    elizarov committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    25b7727 View commit details
    Browse the repository at this point in the history

  9. ~ ChannelOnCancellationFailureTest with more receive fail scenarios

    @elizarov
    elizarov committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    f91919d View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2020

  1. Update kotlinx-coroutines-core/common/test/CancellableResumeTest.kt 

    Co-authored-by: Louis CAD <louis.cognault@gmail.com>
    @elizarov @LouisCAD
    elizarov and LouisCAD committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    356c88c View commit details
    Browse the repository at this point in the history

  2. ~ Added handler failure tests for CancellableContinuation

    @elizarov
    elizarov committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    073c5f3 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. ~ Document details of prompt cancellation

    @elizarov
    elizarov committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    cbc2f8b View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. ~ Fixed channel performance 

    Removed extra CompletedContinuation allocations with channels send/receive
    @elizarov
    elizarov committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    7fac3b7 View commit details
    Browse the repository at this point in the history

  2. ~ Fixed Mutex.onLock cancellation during dispatch

    @elizarov
    elizarov committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    d94759b View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2020

  1. ~ More precise KDoc links to Continuation.resume/resumeWithException … 

    …extensions
    @elizarov
    elizarov committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    d6986ef View commit details
    Browse the repository at this point in the history

  2. ~ Clarified suspendCancellableCoroutine behavior on Job completion, a… 

    …dded test
    @elizarov
    elizarov committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    a2339f2 View commit details
    Browse the repository at this point in the history

  3. ~ Docs typos fixed

    @elizarov
    elizarov committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    5d3cee9 View commit details
    Browse the repository at this point in the history

  4. ~ Inlined MODE_CANCELLABLE_REUSABLE into getOrCreateCancellableContin… 

    …uation
    @elizarov
    elizarov committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    76792fa View commit details
    Browse the repository at this point in the history

  5. ~ Fixed refs to suspendAtomicCancellableCoroutineReusable in docs 

    Changed to suspendCancellableCoroutineReusable
    @elizarov
    elizarov committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    c6aba6c View commit details
    Browse the repository at this point in the history

  6. ~ Fixed code style (extra parens around fun type)

    @elizarov
    elizarov committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    077b0e0 View commit details
    Browse the repository at this point in the history

  7. ~ onElementCancel -> onUndeliveredElement 

    * Consistent type-alias use.
* Rewrote docs to used "element delivery" concept.
    @elizarov
    elizarov committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    9cfcb11 View commit details
    Browse the repository at this point in the history

  8. ~ JvmField AtomicKt.NO_DECISION

    @elizarov
    elizarov committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    e9c6ee3 View commit details
    Browse the repository at this point in the history

  9. ~ Mutex.LockWaiter and its subclasses are inner classes

    @elizarov
    elizarov committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    4674989 View commit details
    Browse the repository at this point in the history

  10. ~ Further naming & code improvements

    @elizarov
    elizarov committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    9b8778e View commit details
    Browse the repository at this point in the history

  11. ~ ArrayBroadcastChannel.kt does not support onUndeliveredElement

    @elizarov
    elizarov committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    aa926fa View commit details
    Browse the repository at this point in the history

  12. ~ Consistent naming: cancelElement() -> undeliveredElement()

    @elizarov
    elizarov committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    7fe569f View commit details
    Browse the repository at this point in the history

  13. ~ Better commend on Send.pollResult

    @elizarov
    elizarov committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    38ec1d0 View commit details
    Browse the repository at this point in the history

  14. ~ Rename tests to xxxUndeliveredElementXxx

    @elizarov
    elizarov committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    a2ed60f View commit details
    Browse the repository at this point in the history

  15. ~ Clarified that Channel.offer does not call onUndeliveredElement

    @elizarov
    elizarov committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    08ce2f8 View commit details
    Browse the repository at this point in the history

  16. ~ Call onUndeliveredElement when channel is closed/cancelled 

    Also more docs and example for onUndeliveredElement usage
    @elizarov
    elizarov committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    c6a07b2 View commit details
    Browse the repository at this point in the history

  17. ~ Test for closed channel fixed

    @elizarov
    elizarov committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    afe8cc3 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. ~ Fixed remaining bugs to handle underlired elements when channel is … 

    …closed.
    @elizarov
    elizarov committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    427117d View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. Update kotlinx-coroutines-core/common/src/channels/AbstractChannel.kt 

    Co-authored-by: Vsevolod Tolstopyatov <qwwdfsad@gmail.com>
    @elizarov @qwwdfsad
    elizarov and qwwdfsad committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    b30d099 View commit details
    Browse the repository at this point in the history

  2. ~ non-inline helpCloseAndGetSendException

    @elizarov
    elizarov committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    85b7812 View commit details
    Browse the repository at this point in the history

  3. ~ undeliveredElementException.cause !== ex optimization

    @elizarov
    elizarov committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    6535659 View commit details
    Browse the repository at this point in the history

  4. ~ Added "since version" for hidden channel constructor

    @elizarov
    elizarov committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    500c911 View commit details
    Browse the repository at this point in the history

  5. ~ Cleaner Semaphore.acquire code in case of immediate elimination wit… 

    …h release
    @elizarov
    elizarov committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    2893470 View commit details
    Browse the repository at this point in the history

  6. Update kotlinx-coroutines-core/common/src/internal/DispatchedTask.kt 

    Co-authored-by: Vsevolod Tolstopyatov <qwwdfsad@gmail.com>
    @elizarov @qwwdfsad
    elizarov and qwwdfsad committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    4760c22 View commit details
    Browse the repository at this point in the history

  7. ~ Fixed cancellation resume mode & CancellableContinuationImpl stack … 

    …trace recovery
    @elizarov
    elizarov committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    6b79de8 View commit details
    Browse the repository at this point in the history

  8. ~ Better diagnostics in ChannelUndeliveredElementStressTest

    @elizarov
    elizarov committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    c88b832 View commit details
    Browse the repository at this point in the history

  9. ~ Fixed bug in ChannelUndeliveredElementStressTest 

    * It must drain the channel before trying to verify.
* A detailed analysis on failure is printed.
    @elizarov
    elizarov committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    4a7eb7a View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2020

  1. ~ Initialize DispatchedContinuation.resumeMode with MODE_UNINITIALIZED 

    This makes code cleaner, highlighting the fact that the actual resumeMode is always set when the continuation is being resumed.
+ added explicit test to ensure that a regular suspendCoroutine from stdlib resumes atomically and ignores cancellation.
    @elizarov
    elizarov committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    5bca7ca View commit details
    Browse the repository at this point in the history

  2. ~ CancellableContinuationImpl.resetState -> resetStateReusable 

    Also, assert mode is MODE_CANCELLABLE_REUSABLE, don't update it.
    @elizarov
    elizarov committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    12bba52 View commit details
    Browse the repository at this point in the history

  3. ~ More tests on double invokeOnCancellation calls 

    Removed old TODO
    @elizarov
    elizarov committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    3df38e9 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2020

  1. ~ Make sure that channel operations allocate memory at the same rate … 

    …as before
    @elizarov
    elizarov committed Oct 7, 2020
    1 Configuration menu
    Copy the full SHA
    164d3e5 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2020

  1. ~ JvmField Itr.channel

    @elizarov
    elizarov committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    4361158 View commit details
    Browse the repository at this point in the history