Add RxJava 3 module #1929
Closed
Add RxJava 3 module #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
requested changes
Apr 22, 2020
| Coroutine builders: | ||
|
|
||
| | **Name** | **Result** | **Scope** | **Description** | ||
| | --------------- | --------------------------------------- | ---------------- | --------------- |
There was a problem hiding this comment.
Please fix the packages in this file in order to make knit task pass without warnings
There was a problem hiding this comment.
Done - f44e6b5. I couldn't find which task in the knit task to run to test this locally though
This isn't the most obvious but I guess it's intentional "I know what I'm doing" code :)
|
Rebased and changed the target to |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1883
I took the liberty of omitting deprecated rx2 APIs from this migration, but it wasn't entirely possible without using
@PublishedApifor a couple of places.There's a decent amount of code duplication involved with this. Could consolidate some for test utilities, but not sure how worth it it is if the rx2 artifact isn't going to see much further development. Let me know 馃憤