Implement optional thread interrupt on coroutine cancellation (#57) #1922
+424
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) See issue Kotlin#57 for details Signed-off-by: Trol <jiaoxiaodong@xiaomi.com>
taralx
reviewed
Apr 19, 2020
| private fun initThread() { | ||
| val thread = Thread.currentThread() | ||
| state.loop { s -> | ||
| when { |
taralx
reviewed
Apr 19, 2020
| override fun invoke(cause: Throwable?) { | ||
| state.loop { s -> | ||
| when { | ||
| s === Init || (s is Working && s.thread === null) -> { |
There was a problem hiding this comment.
If you swap initThread and initInvokeOnCancel then s.thread === null can't happen, right?
There was a problem hiding this comment.
Seems a great idea, I will check it
qwwdfsad
reviewed
Apr 20, 2020
There was a problem hiding this comment.
Great job!
Unfortunately, we are not ready to accept this PR. Changes are intrusive, with a lot of failure modes and corner cases, while the problem it is trying to solve is pretty marginal (especially when you know that a vast majority of Java code doesn't handle interruptions properly). We decided it's not worth to maintain it in a long term, sorry.
jxdabc
pushed a commit
to jxdabc/kotlinx.coroutines
that referenced
this pull request
Apr 22, 2020
…ellation (Kotlin#57) This is implementation of issue Kotlin#57 and non-intrusive variant of Kotlin#1922 Signed-off-by: Trol <jiaoxiaodong@xiaomi.com>
|
Superseded by #1934 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #57 for details
Signed-off-by: Trol jiaoxiaodong@xiaomi.com