Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leak of subscription reference in closed ArrayBroadcastChannel #1885

Merged
merged 1 commit into from Mar 31, 2020
Merged

Fix leak of subscription reference in closed ArrayBroadcastChannel #1885

merged 1 commit into from Mar 31, 2020

Commits on Mar 30, 2020

  1. Fix leak of subscription reference in closed ArrayBroadcastChannel 

    When ArrayBroadcastChannel was closed it was still retaining a reference to its subscription (even if that subscription was cancelled) while, in fact, either closing a broadcast channel or cancelling subscription should remove the reference.

This is no problem with ConflatedBroadcastChannel, but it is added to the test for completeness.
    @elizarov
    elizarov committed Mar 30, 2020
    Copy the full SHA
    e446a5d View commit details
    Browse the repository at this point in the history