Detect missing awaitClose calls in callbackFlow and close channel wit… #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
commented
Jan 20, 2020
qwwdfsad
force-pushed
the
callback-flow
branch
from
2510822
to
4249758
Compare
qwwdfsad
commented
Jan 22, 2020
elizarov
reviewed
Jan 29, 2020
qwwdfsad
force-pushed
the
callback-flow
branch
from
4249758
to
b509739
Compare
elizarov
suggested changes
Jan 29, 2020
kotlinx-coroutines-core/common/src/flow/internal/ChannelFlow.kt
Outdated
Show resolved
Hide resolved
qwwdfsad
force-pushed
the
callback-flow
branch
from
b509739
to
62e6275
Compare
|
Any chance this would end up fixing tfcporciuncula/flow-preferences#1? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…h a proper diagnostic exception
Fixes #1762
Fixes #1770