Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReceiveChannel.broadcast shall start lazy coroutine when closed #1717

Merged
merged 4 commits into from Mar 16, 2020
Merged

ReceiveChannel.broadcast shall start lazy coroutine when closed #1717

merged 4 commits into from Mar 16, 2020

Commits on Mar 16, 2020

  1. ReceiveChannel.broadcast shall start lazy coroutine when closed 

    * Documentation on broadcast operators is added that explains that the resulting BroadcastChannel shall be cancelled if it is not needed anymore.
* More tests added for various broadcast cancel/close cases.
* The only functional change is that closing a broadcast channel for lazy coroutine shall start the corresponding coroutine to give it a chance to promptly fail.
* Mark broadcast operators as obsolete. To be replaced with sharing operators on flows (see #1716).

Fixes #1713
    @elizarov
    elizarov committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    b4ccb30 View commit details
    Browse the repository at this point in the history

  2. ~ Not obsolete until we have replacement

    @elizarov
    elizarov committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    2564dea View commit details
    Browse the repository at this point in the history

  3. ~ Also fix the order of events in lazy actor

    @elizarov
    elizarov committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    9ef76cc View commit details
    Browse the repository at this point in the history

  4. ~ Don't mark broadcast as obsolete yet 

    There is no replacement and it would just makes life harder for people.
    @elizarov
    elizarov committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    59b4067 View commit details
    Browse the repository at this point in the history