Setup cancellation eagerly in suspendCancellableCoroutine to properly… #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Though this change can potentially change behaviour of other libraries (such as retrofit), so I'd postpone it until 1.4 |
qwwdfsad
force-pushed
the
setup-cancellation-eagerly
branch
from
7793e96
to
d680cba
Compare
elizarov
suggested changes
Nov 28, 2019
qwwdfsad
force-pushed
the
setup-cancellation-eagerly
branch
from
d680cba
to
94ac8d2
Compare
elizarov
approved these changes
Dec 11, 2019
qwwdfsad
force-pushed
the
develop
branch
3 times, most recently
from
4a49830
to
aff8202
Compare
… integrate with APIs that may block the current thread, but react on cancellation Fixes #1671
qwwdfsad
force-pushed
the
setup-cancellation-eagerly
branch
from
94ac8d2
to
8fb8d60
Compare
recheej
pushed a commit
to recheej/kotlinx.coroutines
that referenced
this pull request
Dec 28, 2020
… integrate with APIs that may block the current thread, but react on cancellation (Kotlin#1680) Fixes Kotlin#1671
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… integrate with APIs that may block the current thread, but react on cancellation
Fixes #1671