Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethrow downstream exception during "onCompletion" emissions #1658

Merged
merged 1 commit into from Nov 30, 2019

Commits on Nov 12, 2019

  1. Rethrow downstream exception during "onCompletion" emissions

        * We cannot allow emitting elements when downstream exception occurred, otherwise it may lead to a weird side-effects when "collect" block (or any other terminal operator) has thrown an exception, but keeps receiving new values
        * Another solution may be to silently ignore emitted values, but it may lead to a postponed cancellation and surprising behaviour for users
    
    Fixes #1654
    qwwdfsad committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    abced79 View commit details
    Browse the repository at this point in the history