Simplify TestCoroutineScope cleanup

Kotlin · Oct 28, 2021 · e821121 · e821121
1 parent d327ae4
commit e821121
Showing 1 changed file with 14 additions and 10 deletions.
diff --git a/kotlinx-coroutines-test/common/src/TestCoroutineScope.kt b/kotlinx-coroutines-test/common/src/TestCoroutineScope.kt
@@ -45,19 +45,23 @@ private class TestCoroutineScopeImpl(
 
     override fun cleanupTestCoroutines() {
         val delayController = coroutineContext.delayController
-        if (delayController != null) {
-            delayController.cleanupTestCoroutines()
-            coroutineContext.uncaughtExceptionCaptor.cleanupTestCoroutinesCaptor()
+        val hasUnfinishedJobs = if (delayController != null) {
+            try {
+                delayController.cleanupTestCoroutines()
+                false
+            } catch (e: UncompletedCoroutinesError) {
+                true
+            }
         } else {
             testScheduler.runCurrent()
-            coroutineContext.uncaughtExceptionCaptor.cleanupTestCoroutinesCaptor()
-            if (!testScheduler.isIdle()) {
-                throw UncompletedCoroutinesError(
-                    "Unfinished coroutines during teardown. Ensure all coroutines are" +
-                        " completed or cancelled by your test."
-                )
-            }
+            !testScheduler.isIdle()
         }
+        coroutineContext.uncaughtExceptionCaptor.cleanupTestCoroutinesCaptor()
+        if (hasUnfinishedJobs)
+            throw UncompletedCoroutinesError(
+                "Unfinished coroutines during teardown. Ensure all coroutines are" +
+                    " completed or cancelled by your test."
+            )
         val jobs = coroutineContext.activeJobs()
         if ((jobs - initialJobs).isNotEmpty())
             throw UncompletedCoroutinesError("Test finished with active jobs: $jobs")