Skip to content

Commit

Permalink
Remove NPM validation (#3312)
Browse files Browse the repository at this point in the history
We will drop complete support of NPM as soon as JS IR is declared stable and this test is already a deadweight as it was never run due to misconfiguration
  • Loading branch information
qwwdfsad committed Jun 7, 2022
1 parent 110ca3d commit cc5b86a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 93 deletions.
23 changes: 1 addition & 22 deletions integration-testing/build.gradle
Expand Up @@ -14,11 +14,6 @@ repositories {
}

sourceSets {
npmTest {
kotlin
compileClasspath += sourceSets.test.runtimeClasspath
runtimeClasspath += sourceSets.test.runtimeClasspath
}
mavenTest {
kotlin
compileClasspath += sourceSets.test.runtimeClasspath
Expand All @@ -43,20 +38,6 @@ compileDebugAgentTestKotlin {
}
}

task npmTest(type: Test) {
def sourceSet = sourceSets.npmTest
environment "projectRoot", project.rootDir
environment "deployVersion", version
def dryRunNpm = project.properties['dryRun']
def doRun = dryRunNpm == "true" // so that we don't accidentally publish anything, especially before the test
onlyIf { doRun }
if (doRun) { // `onlyIf` only affects execution of the task, not the dependency subtree
dependsOn(project(':').getTasksByName("publishNpm", true))
}
testClassesDirs = sourceSet.output.classesDirs
classpath = sourceSet.runtimeClasspath
}

task mavenTest(type: Test) {
environment "version", version
def sourceSet = sourceSets.mavenTest
Expand Down Expand Up @@ -96,8 +77,6 @@ task coreAgentTest(type: Test) {
dependencies {
testImplementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8"
testImplementation 'junit:junit:4.12'
npmTestImplementation 'org.apache.commons:commons-compress:1.18'
npmTestImplementation 'com.google.code.gson:gson:2.8.5'
debugAgentTestImplementation project(':kotlinx-coroutines-core')
debugAgentTestImplementation project(':kotlinx-coroutines-debug')
coreAgentTestImplementation project(':kotlinx-coroutines-core')
Expand All @@ -108,5 +87,5 @@ compileTestKotlin {
}

check {
dependsOn([npmTest, mavenTest, debugAgentTest, coreAgentTest])
dependsOn([mavenTest, debugAgentTest, coreAgentTest])
}
71 changes: 0 additions & 71 deletions integration-testing/src/npmTest/kotlin/NpmPublicationValidator.kt

This file was deleted.

0 comments on commit cc5b86a

Please sign in to comment.