Don't allocate temporary buffer in SmallPersistentVector.removeAll #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-g
reviewed
Oct 5, 2023
| // Align the mask to the left | ||
| retainedMask = retainedMask shl (Int.SIZE_BITS - size) | ||
|
|
||
| val newBuffer = bufferOfSize(newSize) |
There was a problem hiding this comment.
It could probably make sense to create the new buffer as buffer.copyOf(newSize) to avoid zeroing elements in the newly created buffer and then skip first retained elements there. But that's a guess as well, needs to be benchmarked.
|
Moved review here: #164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually we can avoid the buffer altogether and use 32-bit mask to track retained/removed elements.
Alternative to #134
Again, I don't know which one is faster as I don't run the actual benchmarks