Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designed and implemented Kover API version 2 #190

Merged
merged 10 commits into from Aug 1, 2022
Merged

Designed and implemented Kover API version 2 #190

merged 10 commits into from Aug 1, 2022

Conversation

shanshin
Copy link
Collaborator

Resolves #19
Resolves #128
Resolves #168

@shanshin shanshin added this to the Release 0.6.0 milestone Jun 16, 2022
@k3marek
Copy link

k3marek commented Jun 27, 2022

Hey there; what's your time plans for releasing it?

@shanshin
Copy link
Collaborator Author

Hey there; what's your time plans for releasing it?

@k3marek, the RC version will be published during July, and then we will decide to make a stable release based on feedback.

Copy link
Member

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrific job! My comments are mostly doc-specific and bike-shedding, but overall it looks really promising

README.md Show resolved Hide resolved
src/main/kotlin/kotlinx/kover/api/CoverageEngines.kt Outdated Show resolved Hide resolved
src/main/kotlin/kotlinx/kover/api/CoverageEngines.kt Outdated Show resolved Hide resolved
src/main/kotlin/kotlinx/kover/appliers/KoverTaskApplier.kt Outdated Show resolved Hide resolved
src/main/kotlin/kotlinx/kover/tasks/KoverXmlTask.kt Outdated Show resolved Hide resolved
- Kotlin version upgraded to 1.7.10
- Agent version upgraded to 1.0.675
- instrumentation config added to the test framework
- added test on instrumentation config
- made CoverageEngineVariant as abstract class
- improved docs and comments
@qwwdfsad qwwdfsad removed the request for review from sandwwraith July 27, 2022 10:11
- made CoverageEngineVariant internal
- improved docs and comments
- improved deprecation comments
- changed includes to excludes in projects filter for merged reports
@qwwdfsad qwwdfsad self-requested a review July 28, 2022 17:56
Copy link
Member

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@shanshin shanshin merged commit 6d6ca6c into main Aug 1, 2022
@shanshin shanshin deleted the api-version-2 branch August 1, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants