Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved compile-options.gradle to conventions plugin #434

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

dkrasnoff
Copy link

Moved compile compile-options.gradle to compile-options-conventions.gradle.kts conventions plugin

@dkrasnoff dkrasnoff requested a review from adam-enko May 10, 2024 15:21
@dkrasnoff dkrasnoff force-pushed the build-config/compile-options-convention-plugin branch from 3f126ad to 7051218 Compare May 10, 2024 15:21
@adam-enko
Copy link

One of the tests is failing on TeamCity

https://teamcity.jetbrains.com/buildConfiguration/KotlinTools_KotlinxAtomicfu_SandboxBuildLinuxKotlinMaster/4611908?expandBuildDeploymentsSection=false&hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildProblemsSection=true&expandBuildChangesSection=true

> Task :buildSrc:generateExternalPluginSpecBuilders FAILED
Watching 14 directories to track changes
Watching 14 directories to track changes
Resource missing. [HTTP GET: https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-gradle-plugin/2.0.20-dev-3443/kotlin-gradle-plugin-2.0.20-dev-3443.pom
Found locally available resource with matching checksum: [https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-stdlib/1.9.0/kotlin-stdlib-1.9.0.pom, /mnt/agent/system/gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib/1.9.0/4aea0493dfd3ee18df73bcd97db791c2ea5bb383/kotlin-stdlib-1.9.0.pom]
Found locally available resource with matching checksum: [https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-stdlib-common/1.9.0/kotlin-stdlib-common-1.9.0.pom, /mnt/agent/system/gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib-common/1.9.0/a865a0c5a64618fd1dcca13d05dea4cba44c832/kotlin-stdlib-common-1.9.0.pom]
:generateExternalPluginSpecBuilders
Execution failed for task ':buildSrc:generateExternalPluginSpecBuilders'. org.gradle.api.internal.artifacts.ivyservice.DefaultLenientConfiguration$ArtifactResolveException: Could not resolve all files for configuration ':buildSrc:compileClasspath'.

Is that relevant to the changes here?

@dkrasnoff
Copy link
Author

dkrasnoff commented May 13, 2024

One of the tests is failing on TeamCity

https://teamcity.jetbrains.com/buildConfiguration/KotlinTools_KotlinxAtomicfu_SandboxBuildLinuxKotlinMaster/4611908?expandBuildDeploymentsSection=false&hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildProblemsSection=true&expandBuildChangesSection=true

> Task :buildSrc:generateExternalPluginSpecBuilders FAILED
Watching 14 directories to track changes
Watching 14 directories to track changes
Resource missing. [HTTP GET: https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-gradle-plugin/2.0.20-dev-3443/kotlin-gradle-plugin-2.0.20-dev-3443.pom
Found locally available resource with matching checksum: [https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-stdlib/1.9.0/kotlin-stdlib-1.9.0.pom, /mnt/agent/system/gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib/1.9.0/4aea0493dfd3ee18df73bcd97db791c2ea5bb383/kotlin-stdlib-1.9.0.pom]
Found locally available resource with matching checksum: [https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-stdlib-common/1.9.0/kotlin-stdlib-common-1.9.0.pom, /mnt/agent/system/gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib-common/1.9.0/a865a0c5a64618fd1dcca13d05dea4cba44c832/kotlin-stdlib-common-1.9.0.pom]
:generateExternalPluginSpecBuilders
Execution failed for task ':buildSrc:generateExternalPluginSpecBuilders'. org.gradle.api.internal.artifacts.ivyservice.DefaultLenientConfiguration$ArtifactResolveException: Could not resolve all files for configuration ':buildSrc:compileClasspath'.

Is that relevant to the changes here?

Yes, there were no required repositories in thebuildSrc's settings.gradle.kts file. So, I've added them (copied from main settings.gradle.kts for now).

@dkrasnoff dkrasnoff force-pushed the build-config/compile-options-convention-plugin branch from f4b8012 to 2228f59 Compare May 13, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants