Remove log4j coming from intellij dependencies #3592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmishenev
approved these changes
May 7, 2024
vmishenev
reviewed
May 7, 2024
|
|
||
| implementation(projects.dokkaSubprojects.analysisMarkdownJb) | ||
|
|
||
| implementation(libs.intellij.java.psi.impl) | ||
| implementation(libs.intellij.platform.util.api) |
There was a problem hiding this comment.
Can we remove them from toml as well?
whyoleg
requested review from
IgnatBeresnev
and removed request for
IgnatBeresnev
IgnatBeresnev
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3508
Checked
shadowJarcontents before and after this change: the only difference is in the absence oflog4jclasses.Note: we still include 2 classes from
log4j-LevelandPriority- they are coming fromkotlin-compilerand don't trigger any dependency vulnerability checks.We can drop those classes, and tests are working fine without them, but I've decided not to do this, as if they are used somehow in some situation, it will cause
No class foundexception.Additionally, I've updated some comments and removed confusing dependencies which are not needed in
analysis-kotlin-symbols, as they are coming fromanalysis-java-psiandkotlin-compileranyway - no changes to those classes in finalshadowJarhave happened.