Build script tweaks #3485
Build script tweaks #3485
Conversation
3flex
force-pushed
the
build-tweaks
branch
3 times, most recently
from
23e6910
to
135dc9f
Compare
|
Hi @3flex, thanks for the contribution. I've had a quick scan through and I've applied some of these changes in my own PRs. It makes sense to split them into a separate PR, so thanks for creating this. Updating the scripts to use the new Kotlin Assignment feature is a more notable change however. Dokka needs to support a wide range of Gradle versions, and using Kotlin Assignment requires Gradle 8.2+. We can use Kotlin Assignment in our own build scripts, but not in the tested projects, and probably not in the docs (but I'll check further). |
| languageVersion.set(JavaLanguageVersion.of(11)) | ||
| languageVersion = JavaLanguageVersion.of(11) |
There was a problem hiding this comment.
This version of Dokkatoo isn't connected to anything at the moment, and probably won't be worked on for a while. While editing it won't hurt, it also isn't necessary, so can you remove all of the changes in the dokka-runners/dokkatoo dir please?
| val integrationTestPreparation by tasks.registering { | ||
| tasks.register("integrationTestPreparation") { |
There was a problem hiding this comment.
Can you explain more about this change? Personally I prefer the delegated accessor version over the string-based version.
There was a problem hiding this comment.
It's just shorter and simpler. If you prefer the other way I'll revert.
|
Hey @3flex !
|
GPP redirects to JCenter when it can't find a requested artifact. This is usually not what should happen. Setting Maven first means the order of resolution is Maven Central -> GPP -> JCenter intsead of GPP -> JCenter -> Maven Central.
Pretty low value stuff, but it tidies things up a little here and there.
Easiest to review commit by commit.