Kotlin-as-Java fixes for external invocation #2377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m, DInterface in KaJ.
This PR brings few improvements to Kotlin-as-Java, especially in cases when it is not used as a transformer: - java accessors retains information about original property - companion objects are transformed to java classes (this change is irrelevant to normal execution of dokka, as `companion` property of `DClass` was ignored when KaJ plugin was enabled) - generation of java accessors was unified for classes and objects - lateinit properties are retainings their fields
Comment on lines
+8
to
+11
| class OriginalProperty(val original: DProperty) : ExtraProperty<DFunction> { | ||
| override val key = OriginalProperty | ||
| companion object: ExtraProperty.Key<DFunction, OriginalProperty> | ||
| } |
There was a problem hiding this comment.
Didn't find any actual usages of this - is it something you'll need in the future or use in your plugins?
Also, Out of context, a bit unclear what Original is exactly. Original in relation to what?
After seeing where it's created, it starts to make sense, but maybe it's worth adding a simple KDoc like original property from which a function was created, before any merging or modificatoin took place to save some brain fuel
|
Closing as stale, will revive if need arises |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings few improvements to Kotlin-as-Java, especially in cases when it is not used as a transformer:
companionproperty ofDClasswas ignored when the KaJ plugin was enabled)This is a follow-up PR to the #2353