Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix java getter / setter name generation #2356

Merged
merged 6 commits into from Feb 18, 2022
Merged

Fix java getter / setter name generation #2356

merged 6 commits into from Feb 18, 2022

Commits on Feb 11, 2022

  1. Fix java getter / setter name generation 

    I couldn't find full documentation from kotlin about how these names map beyond:
- https://kotlinlang.org/docs/java-interop.html#getters-and-setters
- https://kotlinlang.org/docs/java-to-kotlin-interop.html#properties

So to double check the edge cases I copied the TestCase class into our own project using kotlin 1.4.20 and saw what java methods were created.
    @CharlesG-Branch
    CharlesG-Branch committed Feb 11, 2022
    Copy the full SHA
    7bf032a View commit details
    Browse the repository at this point in the history

  2. Improve test case

    @CharlesG-Branch
    CharlesG-Branch committed Feb 11, 2022
    Copy the full SHA
    bd38c42 View commit details
    Browse the repository at this point in the history

  3. Don't need !!

    @CharlesG-Branch
    CharlesG-Branch committed Feb 11, 2022
    Copy the full SHA
    db66a62 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2022

  1. Feedback

    @CharlesG-Branch
    CharlesG-Branch committed Feb 14, 2022
    Copy the full SHA
    9286c66 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. Cleanup AccessorMethodNamingTest and add tests for the javadoc output

    @CharlesG-Branch
    CharlesG-Branch committed Feb 16, 2022
    Copy the full SHA
    8358dc9 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2022

  1. Final feedback

    @CharlesG-Branch
    CharlesG-Branch committed Feb 17, 2022
    Copy the full SHA
    7cbc209 View commit details
    Browse the repository at this point in the history