Fix for incorrect rendering of deprecated code #2181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmishenev
force-pushed
the
master
branch
2 times, most recently
from
de135ce
to
4397c96
Compare
|
#2622 Now we have strikethrough only for declaration names and not for the whole signature as before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2177. This PR fixes an issue where consecutive
ContentTextnodes have strikethrough styling. This isn't the best fix, but it's the cleanest as it only changes CommonmarkRenderer. Instead of surroundingContentTextwith~~, it surrounds it with<s>and</s>. I think ideally theContentGroupshould be surrounding with strikethrough instead of each text, but that requires more changes.