Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation details block to pages and strike such pages in navigation #2622

Merged
merged 5 commits into from Aug 18, 2022
Merged

Add deprecation details block to pages and strike such pages in navigation #2622

merged 5 commits into from Aug 18, 2022

Conversation

IgnatBeresnev
Copy link
Member

@IgnatBeresnev IgnatBeresnev commented Aug 11, 2022 •
edited

  • Deprecation details on pages, both for Kotlin and Java Deprecated annotations
  • Strikethrough only declaration names and not for the whole signature as before (so should only be class name, function name, etc)
  • Add text strikethrough for navigation pages where all documentables are deprecated (all and in all source sets)
  • Integrate @DeprecatedSinceKotlin into the block
  • Deprecated declarations are always last on the merged pages, but not on package overview page (as it's sorted by name)

Part of #2576

IgnatBeresnev
IgnatBeresnev commented Aug 11, 2022
View reviewed changes
plugins/base/src/test/kotlin/content/annotations/SinceKotlinTest.kt
Comment on lines -12 to +10
class DepredatedAndSinceKotlinTest : BaseAbstractTest() {
class SinceKotlinTest : BaseAbstractTest() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously:

  • DepredatedAndSinceKotlinTest

Broken into

  • SinceKotlinTest
  • KotlinDeprecatedTest
  • JavaDeprecatedTest

@IgnatBeresnev IgnatBeresnev marked this pull request as ready for review August 12, 2022 14:28
@IgnatBeresnev IgnatBeresnev mentioned this pull request Aug 17, 2022
Closed
@IgnatBeresnev IgnatBeresnev merged commit 50a3323 into master Aug 18, 2022
@IgnatBeresnev IgnatBeresnev deleted the rework-deprecation branch August 18, 2022 17:34
This was referenced Oct 12, 2022
Closed
Closed
@vmishenev vmishenev mentioned this pull request Dec 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmishenev vmishenev vmishenev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IgnatBeresnev @vmishenev