Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change klib validation configuration's callback type to Action #215

Merged
merged 1 commit into from
Apr 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/binary-compatibility-validator.api
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public class kotlinx/validation/ApiValidationExtension {
public final fun getPublicMarkers ()Ljava/util/Set;
public final fun getPublicPackages ()Ljava/util/Set;
public final fun getValidationDisabled ()Z
public final fun klib (Lkotlin/jvm/functions/Function1;)V
public final fun klib (Lorg/gradle/api/Action;)V
public final fun setAdditionalSourceSets (Ljava/util/Set;)V
public final fun setApiDumpDirectory (Ljava/lang/String;)V
public final fun setIgnoredClasses (Ljava/util/Set;)V
Expand Down
5 changes: 3 additions & 2 deletions src/main/kotlin/ApiValidationExtension.kt
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
package kotlinx.validation

import kotlinx.validation.api.klib.KlibSignatureVersion
import org.gradle.api.Action

public open class ApiValidationExtension {

Expand Down Expand Up @@ -86,8 +87,8 @@ public open class ApiValidationExtension {
* Configure KLib ABI validation settings.
*/
@ExperimentalBCVApi
public fun klib(block: KlibValidationSettings.() -> Unit) {
block(this.klib)
public fun klib(config: Action<KlibValidationSettings>) {
config.execute(this.klib)
}
}

Expand Down