Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return partial reports without failure #45

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Aug 10, 2022

This PR aims to address #42 which will make the framework to return reports - even if they're partial - to the caller.

This will have the benefit of returning (and forwarding) even small traces of information instead of simply dropping it on the floor.

@pmalek pmalek requested a review from a team as a code owner August 10, 2022 13:01
@pmalek pmalek self-assigned this Aug 10, 2022
@pmalek pmalek force-pushed the return-partial-reports-without-failure branch from bc9d266 to 8884711 Compare August 10, 2022 13:06
pkg/forwarders/rawchannelforwarder.go Show resolved Hide resolved
pkg/telemetry/consumer.go Outdated Show resolved Hide resolved
pkg/telemetry/consumer.go Show resolved Hide resolved
pkg/telemetry/consumer.go Outdated Show resolved Hide resolved
pkg/logp/logp.go Outdated Show resolved Hide resolved
pkg/logp/logp.go Outdated Show resolved Hide resolved
shaneutt
shaneutt previously approved these changes Aug 11, 2022
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple lingering comments from others which I agree should be resolved before we move on. For instance: I do particularly want to see us get of logrus if feasible. After that LGTM.

@pmalek
Copy link
Member Author

pmalek commented Aug 11, 2022

There are a couple lingering comments from others which I agree should be resolved before we move on. For instance: I do particularly want to see us get of logrus if feasible. After that LGTM.

Do you suggest that we try to remove logrus in this PR?

What would you like to replace it with? I've asked @jrsmroz today and he mentioned that logger work was deprioritized (punted to v3 of KIC) last time we looked at it (in here Kong/kubernetes-ingress-controller#1893) and with that the consensus around what to use instead.

@shaneutt
Copy link
Member

There are a couple lingering comments from others which I agree should be resolved before we move on. For instance: I do particularly want to see us get of logrus if feasible. After that LGTM.

Do you suggest that we try to remove logrus in this PR?

What would you like to replace it with? I've asked @jrsmroz today and he mentioned that logger work was deprioritized (punted to v3 of KIC) last time we looked at it (in here Kong/kubernetes-ingress-controller#1893) and with that the consensus around what to use instead.

If you don't see a quick win in terms of removing the old deprecated logger, then I'm OK with us simply creating a follow-up issue as a resolution here.

@pmalek
Copy link
Member Author

pmalek commented Aug 11, 2022

@pmalek pmalek enabled auto-merge (squash) August 11, 2022 15:23
@pmalek pmalek merged commit 20f386a into main Aug 11, 2022
@pmalek pmalek deleted the return-partial-reports-without-failure branch August 11, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manager: don't abort collecting providers' reports when encountering errors
4 participants