feat: converted loglevels for logrus -> go-logr #1894

shaneutt · 2021-10-04T18:24:12Z

What this PR does / why we need it:

For 2.0 we're launching with multiple logging implementations under the hood, which isn't much of any problem from the end-user perspective and is something we'll converge in time but in the interim we were not properly configuring how we did log levels between the two implementations and had several places that were too noisy and repetitive and needed to be made into debug entries instead of info. This PR takes care of both problems.

Which issue this PR fixes

Resolves #1810

Special notes for your reviewer:

feat: add converted loglevels for go-logr vs logrus
chore: reconfig debug logging for new converter
chore: cleanup some startup log language
chore: run generators

shaneutt · 2021-10-04T19:00:37Z

For illustration here is a sample of INFO level logging with these new changes:

$ go run internal/cmd/main.go --kubeconfig ~/.kube/config --kong-admin-url http://172.18.0.242:8001 --publish-service=kong-system/ingress-controller-kong-proxy --log-level=info
INFO[0000] admission webhook server disabled            
INFO[0000] diagnostics server disabled                  
INFO[0000] getting the kubernetes client configuration   logger=setup
INFO[0000] getting the kong admin api client configuration  logger=setup
INFO[0000] tag filtering enabled                         logger=setup tags="[\"managed-by-ingress-controller\"]"
INFO[0000] configuring and building the controller manager  logger=setup
INFO[0000] metrics server is starting to listen          addr=":10255" logger=controller-runtime.metrics
INFO[0000] Starting Proxy Cache Server                   logger=setup
INFO[0000] Starting Enabled Controllers                  logger=setup
INFO[0000] Starting health check servers                 logger=setup
INFO[0000] Starting anonymous reports                    logger=setup
INFO[0000] Starting resource status updater              logger=setup
INFO[0000] Starting manager                              logger=setup
INFO[0000] starting metrics server                       path=/metrics
INFO[0000] Starting EventSource                          logger=controller.kongclusterplugin reconciler group=configuration.konghq.com reconciler kind=KongClusterPlugin source="{\"Type\":{\"metadata\":{\"creationTimestamp\":null},\"config\":null}}"
INFO[0000] Starting Controller                           logger=controller.kongclusterplugin reconciler group=configuration.konghq.com reconciler kind=KongClusterPlugin
INFO[0000] Starting EventSource                          logger=controller.kongplugin reconciler group=configuration.konghq.com reconciler kind=KongPlugin source="{\"Type\":{\"metadata\":{\"creationTimestamp\":null},\"config\":null}}"
INFO[0000] Starting Controller                           logger=controller.kongplugin reconciler group=configuration.konghq.com reconciler kind=KongPlugin
INFO[0000] Starting EventSource                          logger=controller.kongconsumer reconciler group=configuration.konghq.com reconciler kind=KongConsumer source="{\"Type\":{\"metadata\":{\"creationTimestamp\":null}}}"
INFO[0000] Starting Controller                           logger=controller.kongconsumer reconciler group=configuration.konghq.com reconciler kind=KongConsumer
INFO[0000] Starting EventSource                          logger=controller.endpoints reconciler group= reconciler kind=Endpoints source="{\"Type\":{\"metadata\":{\"creationTimestamp\":null}}}"
INFO[0000] Starting Controller                           logger=controller.endpoints reconciler group= reconciler kind=Endpoints
INFO[0000] Starting EventSource                          logger=controller.kongingress reconciler group=configuration.konghq.com reconciler kind=KongIngress source="{\"Type\":{\"metadata\":{\"creationTimestamp\":null}}}"
INFO[0000] Starting Controller                           logger=controller.kongingress reconciler group=configuration.konghq.com reconciler kind=KongIngress
INFO[0000] Starting EventSource                          logger=controller.ingress reconciler group=networking.k8s.io reconciler kind=Ingress source="{\"Type\":{\"metadata\":{\"creationTimestamp\":null},\"spec\":{},\"status\":{\"loadBalancer\":{}}}}"
INFO[0000] Starting Controller                           logger=controller.ingress reconciler group=networking.k8s.io reconciler kind=Ingress
INFO[0000] Starting EventSource                          logger=controller.udpingress reconciler group=configuration.konghq.com reconciler kind=UDPIngress source="{\"Type\":{\"metadata\":{\"creationTimestamp\":null},\"spec\":{},\"status\":{\"loadBalancer\":{}}}}"
INFO[0000] Starting Controller                           logger=controller.udpingress reconciler group=configuration.konghq.com reconciler kind=UDPIngress
INFO[0000] Starting EventSource                          logger=controller.tcpingress reconciler group=configuration.konghq.com reconciler kind=TCPIngress source="{\"Type\":{\"metadata\":{\"creationTimestamp\":null},\"spec\":{},\"status\":{\"loadBalancer\":{}}}}"
INFO[0000] Starting Controller                           logger=controller.tcpingress reconciler group=configuration.konghq.com reconciler kind=TCPIngress
INFO[0000] Starting EventSource                          logger=controller.secret reconciler group= reconciler kind=Secret source="{\"Type\":{\"metadata\":{\"creationTimestamp\":null}}}"
INFO[0000] Starting Controller                           logger=controller.secret reconciler group= reconciler kind=Secret
INFO[0000] Starting EventSource                          logger=controller.service reconciler group= reconciler kind=Service source="{\"Type\":{\"metadata\":{\"creationTimestamp\":null},\"spec\":{},\"status\":{\"loadBalancer\":{}}}}"
INFO[0000] Starting Controller                           logger=controller.service reconciler group= reconciler kind=Service
INFO[0000] Starting workers                              logger=controller.endpoints reconciler group= reconciler kind=Endpoints worker count=1
INFO[0000] Starting workers                              logger=controller.kongclusterplugin reconciler group=configuration.konghq.com reconciler kind=KongClusterPlugin worker count=1
INFO[0000] Starting workers                              logger=controller.ingress reconciler group=networking.k8s.io reconciler kind=Ingress worker count=1
INFO[0000] Starting workers                              logger=controller.secret reconciler group= reconciler kind=Secret worker count=1
INFO[0000] Starting workers                              logger=controller.kongplugin reconciler group=configuration.konghq.com reconciler kind=KongPlugin worker count=1
INFO[0000] Starting workers                              logger=controller.kongconsumer reconciler group=configuration.konghq.com reconciler kind=KongConsumer worker count=1
INFO[0000] Starting workers                              logger=controller.kongingress reconciler group=configuration.konghq.com reconciler kind=KongIngress worker count=1
INFO[0000] Starting workers                              logger=controller.udpingress reconciler group=configuration.konghq.com reconciler kind=UDPIngress worker count=1
INFO[0000] Starting workers                              logger=controller.service reconciler group= reconciler kind=Service worker count=1
INFO[0000] Starting workers                              logger=controller.tcpingress reconciler group=configuration.konghq.com reconciler kind=TCPIngress worker count=1
INFO[0004] successfully synced configuration to kong.    subsystem=proxy-cache-resolver
INFO[0529] successfully synced configuration to kong.    subsystem=proxy-cache-resolver

And a sample of debug:

$ go run internal/cmd/main.go --kubeconfig ~/.kube/config --kong-admin-url http://172.18.0.242:8001 --publish-service=kong-system/ingress-controller-kong-proxy --log-level=debug
INFO[0000] admission webhook server disabled            
INFO[0000] diagnostics server disabled                  
INFO[0000] starting controller manager                   commit=UNKNOWN logger=setup release=UNKNOWN repo=UNKNOWN
INFO[0000] the ingress class name has been set           logger=setup value=kong
INFO[0000] building the manager runtime scheme and loading apis into the scheme  logger=setup
INFO[0000] getting the kubernetes client configuration   logger=setup
INFO[0000] getting the kong admin api client configuration  logger=setup
INFO[0000] tag filtering enabled                         logger=setup tags="[\"managed-by-ingress-controller\"]"
INFO[0000] configuring and building the controller manager  logger=setup
INFO[0000] metrics server is starting to listen          addr=":10255" logger=controller-runtime.metrics
INFO[0000] Starting Proxy Cache Server                   logger=setup
INFO[0000] Starting Enabled Controllers                  logger=setup
INFO[0000] Starting health check servers                 logger=setup
INFO[0000] Starting anonymous reports                    logger=setup
INFO[0000] Starting resource status updater              logger=setup
INFO[0000] Starting manager                              logger=setup
INFO[0000] starting metrics server                       path=/metrics
INFO[0000] Starting EventSource                          logger=controller.kongconsumer reconciler group=configuration.konghq.com reconciler kind=KongConsumer source="{\"Type\":{\"metadata\":{\"creationTimestamp\":null}}}"
INFO[0000] Starting EventSource                          logger=controller.kongclusterplugin reconciler group=configuration.konghq.com reconciler kind=KongClusterPlugin source="{\"Type\":{\"metadata\":{\"creationTimestamp\":null},\"config\":null}}"
INFO[0000] Starting Controller                           logger=controller.kongclusterplugin reconciler group=configuration.konghq.com reconciler kind=KongClusterPlugin
INFO[0000] Starting Controller                           logger=controller.kongconsumer reconciler group=configuration.konghq.com reconciler kind=KongConsumer
INFO[0000] Starting EventSource                          logger=controller.secret reconciler group= reconciler kind=Secret source="{\"Type\":{\"metadata\":{\"creationTimestamp\":null}}}"
INFO[0000] Starting Controller                           logger=controller.secret reconciler group= reconciler kind=Secret
INFO[0000] Starting EventSource                          logger=controller.udpingress reconciler group=configuration.konghq.com reconciler kind=UDPIngress source="{\"Type\":{\"metadata\":{\"creationTimestamp\":null},\"spec\":{},\"status\":{\"loadBalancer\":{}}}}"
INFO[0000] Starting Controller                           logger=controller.udpingress reconciler group=configuration.konghq.com reconciler kind=UDPIngress
INFO[0000] Starting EventSource                          logger=controller.ingress reconciler group=networking.k8s.io reconciler kind=Ingress source="{\"Type\":{\"metadata\":{\"creationTimestamp\":null},\"spec\":{},\"status\":{\"loadBalancer\":{}}}}"
INFO[0000] Starting EventSource                          logger=controller.kongplugin reconciler group=configuration.konghq.com reconciler kind=KongPlugin source="{\"Type\":{\"metadata\":{\"creationTimestamp\":null},\"config\":null}}"
INFO[0000] Starting Controller                           logger=controller.kongplugin reconciler group=configuration.konghq.com reconciler kind=KongPlugin
INFO[0000] Starting EventSource                          logger=controller.tcpingress reconciler group=configuration.konghq.com reconciler kind=TCPIngress source="{\"Type\":{\"metadata\":{\"creationTimestamp\":null},\"spec\":{},\"status\":{\"loadBalancer\":{}}}}"
INFO[0000] Starting Controller                           logger=controller.ingress reconciler group=networking.k8s.io reconciler kind=Ingress
INFO[0000] Starting EventSource                          logger=controller.service reconciler group= reconciler kind=Service source="{\"Type\":{\"metadata\":{\"creationTimestamp\":null},\"spec\":{},\"status\":{\"loadBalancer\":{}}}}"
INFO[0000] Starting Controller                           logger=controller.service reconciler group= reconciler kind=Service
INFO[0000] Starting Controller                           logger=controller.tcpingress reconciler group=configuration.konghq.com reconciler kind=TCPIngress
INFO[0000] Starting EventSource                          logger=controller.kongingress reconciler group=configuration.konghq.com reconciler kind=KongIngress source="{\"Type\":{\"metadata\":{\"creationTimestamp\":null}}}"
INFO[0000] Starting Controller                           logger=controller.kongingress reconciler group=configuration.konghq.com reconciler kind=KongIngress
INFO[0000] Starting EventSource                          logger=controller.endpoints reconciler group= reconciler kind=Endpoints source="{\"Type\":{\"metadata\":{\"creationTimestamp\":null}}}"
INFO[0000] Starting Controller                           logger=controller.endpoints reconciler group= reconciler kind=Endpoints
INFO[0000] Starting workers                              logger=controller.kongconsumer reconciler group=configuration.konghq.com reconciler kind=KongConsumer worker count=1
INFO[0000] Starting workers                              logger=controller.kongclusterplugin reconciler group=configuration.konghq.com reconciler kind=KongClusterPlugin worker count=1
INFO[0000] Starting workers                              logger=controller.endpoints reconciler group= reconciler kind=Endpoints worker count=1
INFO[0000] Starting workers                              logger=controller.tcpingress reconciler group=configuration.konghq.com reconciler kind=TCPIngress worker count=1
INFO[0000] Starting workers                              logger=controller.service reconciler group= reconciler kind=Service worker count=1
INFO[0000] reconciling resource                          CoreV1Endpoints="{\"Namespace\":\"kong-system\",\"Name\":\"ingress-controller-kong-admin\"}" logger=controllers.Endpoints name=ingress-controller-kong-admin namespace=kong-system
INFO[0000] reconciling resource                          CoreV1Service="{\"Namespace\":\"default\",\"Name\":\"nginx1\"}" logger=controllers.Service name=nginx1 namespace=default
INFO[0000] reconciling resource                          CoreV1Endpoints="{\"Namespace\":\"kong-system\",\"Name\":\"ingress-controller-kong-proxy\"}" logger=controllers.Endpoints name=ingress-controller-kong-proxy namespace=kong-system
INFO[0000] reconciling resource                          CoreV1Service="{\"Namespace\":\"default\",\"Name\":\"nginx2\"}" logger=controllers.Service name=nginx2 namespace=default
INFO[0000] reconciling resource                          CoreV1Endpoints="{\"Namespace\":\"kong-system\",\"Name\":\"ingress-controller-kong-udp\"}" logger=controllers.Endpoints name=ingress-controller-kong-udp namespace=kong-system
INFO[0000] reconciling resource                          CoreV1Service="{\"Namespace\":\"default\",\"Name\":\"kubernetes\"}" logger=controllers.Service name=kubernetes namespace=default
INFO[0000] reconciling resource                          CoreV1Endpoints="{\"Namespace\":\"local-path-storage\",\"Name\":\"rancher.io-local-path\"}" logger=controllers.Endpoints name=rancher.io-local-path namespace=local-path-storage
INFO[0000] reconciling resource                          CoreV1Endpoints="{\"Namespace\":\"default\",\"Name\":\"nginx1\"}" logger=controllers.Endpoints name=nginx1 namespace=default
INFO[0000] reconciling resource                          CoreV1Service="{\"Namespace\":\"kube-system\",\"Name\":\"kube-dns\"}" logger=controllers.Service name=kube-dns namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Endpoints="{\"Namespace\":\"default\",\"Name\":\"nginx2\"}" logger=controllers.Endpoints name=nginx2 namespace=default
INFO[0000] reconciling resource                          CoreV1Service="{\"Namespace\":\"kong-system\",\"Name\":\"ingress-controller-kong-admin\"}" logger=controllers.Service name=ingress-controller-kong-admin namespace=kong-system
INFO[0000] reconciling resource                          CoreV1Endpoints="{\"Namespace\":\"default\",\"Name\":\"kubernetes\"}" logger=controllers.Endpoints name=kubernetes namespace=default
INFO[0000] reconciling resource                          CoreV1Service="{\"Namespace\":\"kong-system\",\"Name\":\"ingress-controller-kong-proxy\"}" logger=controllers.Service name=ingress-controller-kong-proxy namespace=kong-system
INFO[0000] reconciling resource                          CoreV1Endpoints="{\"Namespace\":\"kube-system\",\"Name\":\"kube-dns\"}" logger=controllers.Endpoints name=kube-dns namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Service="{\"Namespace\":\"kong-system\",\"Name\":\"ingress-controller-kong-udp\"}" logger=controllers.Service name=ingress-controller-kong-udp namespace=kong-system
INFO[0000] Starting workers                              logger=controller.udpingress reconciler group=configuration.konghq.com reconciler kind=UDPIngress worker count=1
INFO[0000] Starting workers                              logger=controller.secret reconciler group= reconciler kind=Secret worker count=1
INFO[0000] Starting workers                              logger=controller.kongplugin reconciler group=configuration.konghq.com reconciler kind=KongPlugin worker count=1
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"service-controller-token-stk5b\"}" logger=controllers.Secrets name=service-controller-token-stk5b namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"generic-garbage-collector-token-f55md\"}" logger=controllers.Secrets name=generic-garbage-collector-token-f55md namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"clusterrole-aggregation-controller-token-2hwlx\"}" logger=controllers.Secrets name=clusterrole-aggregation-controller-token-2hwlx namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"metallb-system\",\"Name\":\"speaker-token-68fxg\"}" logger=controllers.Secrets name=speaker-token-68fxg namespace=metallb-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"endpointslice-controller-token-klfml\"}" logger=controllers.Secrets name=endpointslice-controller-token-klfml namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"service-account-controller-token-hfqdl\"}" logger=controllers.Secrets name=service-account-controller-token-hfqdl namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"certificate-controller-token-7fw64\"}" logger=controllers.Secrets name=certificate-controller-token-7fw64 namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"metallb-system\",\"Name\":\"controller-token-gjk7d\"}" logger=controllers.Secrets name=controller-token-gjk7d namespace=metallb-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"disruption-controller-token-4flsh\"}" logger=controllers.Secrets name=disruption-controller-token-4flsh namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"bootstrap-signer-token-vdb7m\"}" logger=controllers.Secrets name=bootstrap-signer-token-vdb7m namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-public\",\"Name\":\"default-token-f5xcr\"}" logger=controllers.Secrets name=default-token-f5xcr namespace=kube-public
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"namespace-controller-token-4nzmd\"}" logger=controllers.Secrets name=namespace-controller-token-4nzmd namespace=kube-system
INFO[0000] Starting workers                              logger=controller.kongingress reconciler group=configuration.konghq.com reconciler kind=KongIngress worker count=1
INFO[0000] Starting workers                              logger=controller.ingress reconciler group=networking.k8s.io reconciler kind=Ingress worker count=1
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"replication-controller-token-25lrh\"}" logger=controllers.Secrets name=replication-controller-token-25lrh namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"attachdetach-controller-token-9hfhg\"}" logger=controllers.Secrets name=attachdetach-controller-token-9hfhg namespace=kube-system
INFO[0000] reconciling resource                          NetV1Ingress="{\"Namespace\":\"default\",\"Name\":\"nginx1\"}" logger=controllers.Ingress.netv1 name=nginx1 namespace=default
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"persistent-volume-binder-token-rlnb7\"}" logger=controllers.Secrets name=persistent-volume-binder-token-rlnb7 namespace=kube-system
INFO[0000] reconciling resource                          NetV1Ingress="{\"Namespace\":\"default\",\"Name\":\"nginx2\"}" logger=controllers.Ingress.netv1 name=nginx2 namespace=default
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"node-controller-token-rc74n\"}" logger=controllers.Secrets name=node-controller-token-rc74n namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"pod-garbage-collector-token-nx78m\"}" logger=controllers.Secrets name=pod-garbage-collector-token-nx78m namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"ephemeral-volume-controller-token-7n7c9\"}" logger=controllers.Secrets name=ephemeral-volume-controller-token-7n7c9 namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"ttl-controller-token-r646v\"}" logger=controllers.Secrets name=ttl-controller-token-r646v namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kong-system\",\"Name\":\"default-token-6q9zn\"}" logger=controllers.Secrets name=default-token-6q9zn namespace=kong-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"resourcequota-controller-token-vvgv6\"}" logger=controllers.Secrets name=resourcequota-controller-token-vvgv6 namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"statefulset-controller-token-tzrv6\"}" logger=controllers.Secrets name=statefulset-controller-token-tzrv6 namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"ttl-after-finished-controller-token-2v9kv\"}" logger=controllers.Secrets name=ttl-after-finished-controller-token-2v9kv namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"bootstrap-token-abcdef\"}" logger=controllers.Secrets name=bootstrap-token-abcdef namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-node-lease\",\"Name\":\"default-token-qdxd2\"}" logger=controllers.Secrets name=default-token-qdxd2 namespace=kube-node-lease
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"coredns-token-9krs9\"}" logger=controllers.Secrets name=coredns-token-9krs9 namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"job-controller-token-hrcm6\"}" logger=controllers.Secrets name=job-controller-token-hrcm6 namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"expand-controller-token-vbj92\"}" logger=controllers.Secrets name=expand-controller-token-vbj92 namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"pv-protection-controller-token-jt85d\"}" logger=controllers.Secrets name=pv-protection-controller-token-jt85d namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"daemon-set-controller-token-tjf88\"}" logger=controllers.Secrets name=daemon-set-controller-token-tjf88 namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"kube-proxy-token-9qcg7\"}" logger=controllers.Secrets name=kube-proxy-token-9qcg7 namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"local-path-storage\",\"Name\":\"default-token-9rhxf\"}" logger=controllers.Secrets name=default-token-9rhxf namespace=local-path-storage
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"endpoint-controller-token-qqs9c\"}" logger=controllers.Secrets name=endpoint-controller-token-qqs9c namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"default\",\"Name\":\"default-token-k45gb\"}" logger=controllers.Secrets name=default-token-k45gb namespace=default
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"local-path-storage\",\"Name\":\"local-path-provisioner-service-account-token-jdxdl\"}" logger=controllers.Secrets name=local-path-provisioner-service-account-token-jdxdl namespace=local-path-storage
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kong-system\",\"Name\":\"sh.helm.release.v1.ingress-controller.v1\"}" logger=controllers.Secrets name=sh.helm.release.v1.ingress-controller.v1 namespace=kong-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"cronjob-controller-token-dtfwz\"}" logger=controllers.Secrets name=cronjob-controller-token-dtfwz namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"deployment-controller-token-wpbv8\"}" logger=controllers.Secrets name=deployment-controller-token-wpbv8 namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"horizontal-pod-autoscaler-token-8ppqw\"}" logger=controllers.Secrets name=horizontal-pod-autoscaler-token-8ppqw namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"replicaset-controller-token-nmfnn\"}" logger=controllers.Secrets name=replicaset-controller-token-nmfnn namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"metallb-system\",\"Name\":\"memberlist\"}" logger=controllers.Secrets name=memberlist namespace=metallb-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"root-ca-cert-publisher-token-wqtk8\"}" logger=controllers.Secrets name=root-ca-cert-publisher-token-wqtk8 namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"metallb-system\",\"Name\":\"default-token-gvkhz\"}" logger=controllers.Secrets name=default-token-gvkhz namespace=metallb-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"pvc-protection-controller-token-zlmr6\"}" logger=controllers.Secrets name=pvc-protection-controller-token-zlmr6 namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"default-token-4cn75\"}" logger=controllers.Secrets name=default-token-4cn75 namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"token-cleaner-token-tpz72\"}" logger=controllers.Secrets name=token-cleaner-token-tpz72 namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"ktf-system\",\"Name\":\"default-token-7ws57\"}" logger=controllers.Secrets name=default-token-7ws57 namespace=ktf-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"endpointslicemirroring-controller-token-gvlw9\"}" logger=controllers.Secrets name=endpointslicemirroring-controller-token-gvlw9 namespace=kube-system
INFO[0000] reconciling resource                          CoreV1Secret="{\"Namespace\":\"kube-system\",\"Name\":\"kindnet-token-s2hxp\"}" logger=controllers.Secrets name=kindnet-token-s2hxp namespace=kube-system
INFO[0001] reconciling resource                          CoreV1Endpoints="{\"Namespace\":\"local-path-storage\",\"Name\":\"rancher.io-local-path\"}" logger=controllers.Endpoints name=rancher.io-local-path namespace=local-path-storage
DEBU[0003] fetching endpoints                            service_name=nginx1 service_namespace=default service_port="&ServicePort{Name:,Protocol:TCP,Port:80,TargetPort:{0 80 },NodePort:0,AppProtocol:nil,}" subsystem=proxy-cache-resolver
DEBU[0003] found endpoints: [{10.244.0.7 80}]            service_name=nginx1 service_namespace=default service_port="&ServicePort{Name:,Protocol:TCP,Port:80,TargetPort:{0 80 },NodePort:0,AppProtocol:nil,}" subsystem=proxy-cache-resolver
DEBU[0003] fetching endpoints                            service_name=nginx2 service_namespace=default service_port="&ServicePort{Name:,Protocol:TCP,Port:80,TargetPort:{0 80 },NodePort:0,AppProtocol:nil,}" subsystem=proxy-cache-resolver
DEBU[0003] found endpoints: [{10.244.0.8 80}]            service_name=nginx2 service_namespace=default service_port="&ServicePort{Name:,Protocol:TCP,Port:80,TargetPort:{0 80 },NodePort:0,AppProtocol:nil,}" subsystem=proxy-cache-resolver
INFO[0003] reconciling resource                          CoreV1Endpoints="{\"Namespace\":\"local-path-storage\",\"Name\":\"rancher.io-local-path\"}" logger=controllers.Endpoints name=rancher.io-local-path namespace=local-path-storage
INFO[0004] successfully synced configuration to kong.    subsystem=proxy-cache-resolver
INFO[0004] data-plane updates completed, updating resource statuses 
INFO[0005] reconciling resource                          CoreV1Endpoints="{\"Namespace\":\"local-path-storage\",\"Name\":\"rancher.io-local-path\"}" logger=controllers.Endpoints name=rancher.io-local-path namespace=local-path-storage
DEBU[0006] fetching endpoints                            service_name=nginx1 service_namespace=default service_port="&ServicePort{Name:,Protocol:TCP,Port:80,TargetPort:{0 80 },NodePort:0,AppProtocol:nil,}" subsystem=proxy-cache-resolver
DEBU[0006] found endpoints: [{10.244.0.7 80}]            service_name=nginx1 service_namespace=default service_port="&ServicePort{Name:,Protocol:TCP,Port:80,TargetPort:{0 80 },NodePort:0,AppProtocol:nil,}" subsystem=proxy-cache-resolver
DEBU[0006] fetching endpoints                            service_name=nginx2 service_namespace=default service_port="&ServicePort{Name:,Protocol:TCP,Port:80,TargetPort:{0 80 },NodePort:0,AppProtocol:nil,}" subsystem=proxy-cache-resolver
DEBU[0006] found endpoints: [{10.244.0.8 80}]            service_name=nginx2 service_namespace=default service_port="&ServicePort{Name:,Protocol:TCP,Port:80,TargetPort:{0 80 },NodePort:0,AppProtocol:nil,}" subsystem=proxy-cache-resolver
DEBU[0006] sha 388e7cd3cbde71c8ec9d4fed09e751c48641fc3be4ea90748897a0a64012d529 has been reported  subsystem=proxy-cache-resolver
DEBU[0006] no configuration change, skipping sync to kong  subsystem=proxy-cache-resolver
INFO[0007] reconciling resource                          CoreV1Endpoints="{\"Namespace\":\"local-path-storage\",\"Name\":\"rancher.io-local-path\"}" logger=controllers.Endpoints name=rancher.io-local-path namespace=local-path-storage
DEBU[0009] fetching endpoints                            service_name=nginx1 service_namespace=default service_port="&ServicePort{Name:,Protocol:TCP,Port:80,TargetPort:{0 80 },NodePort:0,AppProtocol:nil,}" subsystem=proxy-cache-resolver
DEBU[0009] found endpoints: [{10.244.0.7 80}]            service_name=nginx1 service_namespace=default service_port="&ServicePort{Name:,Protocol:TCP,Port:80,TargetPort:{0 80 },NodePort:0,AppProtocol:nil,}" subsystem=proxy-cache-resolver
DEBU[0009] fetching endpoints                            service_name=nginx2 service_namespace=default service_port="&ServicePort{Name:,Protocol:TCP,Port:80,TargetPort:{0 80 },NodePort:0,AppProtocol:nil,}" subsystem=proxy-cache-resolver
DEBU[0009] found endpoints: [{10.244.0.8 80}]            service_name=nginx2 service_namespace=default service_port="&ServicePort{Name:,Protocol:TCP,Port:80,TargetPort:{0 80 },NodePort:0,AppProtocol:nil,}" subsystem=proxy-cache-resolver
DEBU[0009] no configuration change, skipping sync to kong  subsystem=proxy-cache-resolver
INFO[0009] reconciling resource                          CoreV1Endpoints="{\"Namespace\":\"local-path-storage\",\"Name\":\"rancher.io-local-path\"}" logger=controllers.Endpoints name=rancher.io-local-path namespace=local-path-storage

shaneutt · 2021-10-04T19:01:37Z

As per the above log outputs I've been testing this locally, and things look good to me from a usability/UX standpoint.

shaneutt added 4 commits October 4, 2021 14:18

feat: add converted loglevels for go-logr vs logrus

0d682da

chore: reconfig debug logging for new converter

e1fc8a2

chore: cleanup some startup log language

443fefa

chore: run generators

5a2cec7

shaneutt added priority/low area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. labels Oct 4, 2021

shaneutt added this to the Blockers for KIC 2.0 GA milestone Oct 4, 2021

shaneutt self-assigned this Oct 4, 2021

shaneutt temporarily deployed to Configure ci October 4, 2021 18:24 Inactive

github-actions bot added the ci/license/unchanged label Oct 4, 2021

shaneutt temporarily deployed to Configure ci October 4, 2021 18:33 Inactive

shaneutt marked this pull request as ready for review October 4, 2021 18:34

shaneutt requested a review from a team as a code owner October 4, 2021 18:34

shaneutt requested review from mflendrich and rainest October 4, 2021 18:34

shaneutt changed the title ~~shaneutt/controller manager log levels~~ feat: converted loglevels for logrus -> go-logr Oct 4, 2021

shaneutt enabled auto-merge (rebase) October 4, 2021 19:00

rainest approved these changes Oct 4, 2021

View reviewed changes

shaneutt merged commit 67f9941 into main Oct 4, 2021

shaneutt deleted the shaneutt/controller-manager-log-levels branch October 4, 2021 19:46

mflendrich mentioned this pull request Oct 8, 2021

feat(log): log the KIC version by default #1911

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: converted loglevels for logrus -> go-logr #1894

feat: converted loglevels for logrus -> go-logr #1894

shaneutt commented Oct 4, 2021

shaneutt commented Oct 4, 2021

shaneutt commented Oct 4, 2021

feat: converted loglevels for logrus -> go-logr #1894

feat: converted loglevels for logrus -> go-logr #1894

Conversation

shaneutt commented Oct 4, 2021

shaneutt commented Oct 4, 2021

shaneutt commented Oct 4, 2021