Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make controller manager logs less chatty #1810

Closed
1 of 4 tasks
mflendrich opened this issue Sep 8, 2021 · 1 comment · Fixed by #1894
Closed
1 of 4 tasks

Make controller manager logs less chatty #1810

mflendrich opened this issue Sep 8, 2021 · 1 comment · Fixed by #1894
Assignees
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. priority/low waiting-on-pr-review This work is on-hold, specifically because no further work can be done until review is complete

Comments

@mflendrich
Copy link
Member

mflendrich commented Sep 8, 2021

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

There is a lot of output in the logs, including the initialization phase and normal operation.
Let's see if we can improve log readability for a user searching for a concrete problem.

time="2021-09-03T20:45:09Z" level=info msg="admission webhook server disabled"                                                                                                                                     
time="2021-09-03T20:45:09Z" level=info msg="diagnostics server disabled"                                                                                                                                           
time="2021-09-03T20:45:09Z" level=info msg="starting controller manager" commit=UNKNOWN logger=setup release=UNKNOWN repo=UNKNOWN                                                                                  
time="2021-09-03T20:45:09Z" level=info msg="the ingress class name has been set" logger=setup value=kong                                                                                                           
time="2021-09-03T20:45:09Z" level=info msg="building the manager runtime scheme and loading apis into the scheme" logger=setup                                                                                     
time="2021-09-03T20:45:09Z" level=info msg="getting the kubernetes client configuration" logger=setup                                                                                                              
W0903 20:45:09.013822       1 client_config.go:615] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.                                                             
time="2021-09-03T20:45:09Z" level=info msg="getting the kong admin api client configuration" logger=setup                                                                                                          
time="2021-09-03T20:45:09Z" level=info msg="tag filtering enabled" logger=setup tags="[\"managed-by-ingress-controller\"]"                                                                                         
time="2021-09-03T20:45:09Z" level=info msg="configuring and building the controller manager" logger=setup                                                                                                          
time="2021-09-03T20:45:09Z" level=info msg="metrics server is starting to listen" addr=":10255" logger=controller-runtime.metrics                                                                                  
time="2021-09-03T20:45:09Z" level=info msg="configuring and building the proxy cache server" logger=setup                                                                                                          
...

Proposed Solution

Reduce verbosity (logr does not support log levels) of logging by default, and ensure that normal operation results in only as much logging as necessary to see that KIC is up and running.

  • make DP update log prints hidden by default

Additional information

No response

Acceptance Criteria

  • Walked through the prints produced by a live instance of KIC
  • DP update log prints hidden by default
  • Any other reasonably unnecessary items hidden by default as well
@shaneutt shaneutt self-assigned this Oct 4, 2021
@shaneutt shaneutt added this to the Blockers for KIC 2.0 GA milestone Oct 4, 2021
@shaneutt shaneutt changed the title Make railgun logs less chatty Make controller manager logs less chatty Oct 4, 2021
@shaneutt
Copy link
Member

shaneutt commented Oct 4, 2021

#1893 is related to this (but there are no dependencies) as we will in time want to unify our controller manager logging implementation.

@shaneutt shaneutt added waiting-on-pr-review This work is on-hold, specifically because no further work can be done until review is complete area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. labels Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. priority/low waiting-on-pr-review This work is on-hold, specifically because no further work can be done until review is complete
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants