fix(ai-proxy): Fix Cohere breaks with model parameter in body; Fix OpenAI token counting for function requests; Fix user sending own-model parameter #13000
+272
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cherry-pick kong-ee
|
Happy 13,000th pull request!! |
tysoekong
force-pushed
the
fix/ai_proxy_rc2_feedback
branch
3 times, most recently
from
3cd4e1a
to
7bef31f
Compare
|
changes look fine, the commit message as well the linked ticket description should be more descriptive, let's describe what's actually being fixed instead of |
tysoekong
changed the title
tysoekong
force-pushed
the
fix/ai_proxy_rc2_feedback
branch
from
22acec9
to
ec2ad3e
Compare
tysoekong
force-pushed
the
fix/ai_proxy_rc2_feedback
branch
from
f3d71c5
to
0a93131
Compare
|
@tysoekong please resolve conflict. would be ideal if you keep 4 commits as there're four changelogs, as it may become headache if we want to revert one of them. not a hard blocker though. |
|
I just have to also investigate the streaming issue, it would make no sense to leave unpatched. |
tysoekong
force-pushed
the
fix/ai_proxy_rc2_feedback
branch
from
0a93131
to
a4110b9
Compare
tysoekong
force-pushed
the
fix/ai_proxy_rc2_feedback
branch
3 times, most recently
from
ec64781
to
7d54c33
Compare
tysoekong
force-pushed
the
fix/ai_proxy_rc2_feedback
branch
from
7d54c33
to
082be0c
Compare
fffonion
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Minor fix rollup from RC2, for function calling fixes and other broken AI config checks.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-4596