Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump grpcurl from 1.8.5 to 1.9.1 #11987

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 1 addition & 7 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -43,17 +43,12 @@ endif

ROOT_DIR:=$(shell dirname $(realpath $(lastword $(MAKEFILE_LIST))))
KONG_SOURCE_LOCATION ?= $(ROOT_DIR)
GRPCURL_VERSION ?= 1.8.5
GRPCURL_VERSION ?= 1.9.1
BAZLISK_VERSION ?= 1.19.0
H2CLIENT_VERSION ?= 0.4.4
BAZEL := $(shell command -v bazel 2> /dev/null)
VENV = /dev/null # backward compatibility when no venv is built

# Use x86_64 grpcurl v1.8.5 for Apple silicon chips
ifeq ($(GRPCURL_OS)_$(MACHINE)_$(GRPCURL_VERSION), osx_arm64_1.8.5)
GRPCURL_MACHINE = x86_64
endif

PACKAGE_TYPE ?= deb

bin/bazel:
Expand All @@ -71,7 +66,6 @@ bin/h2client:
https://github.com/Kong/h2client/releases/download/v$(H2CLIENT_VERSION)/h2client_$(H2CLIENT_VERSION)_$(OS)_$(H2CLIENT_MACHINE).tar.gz | tar xz -C bin;
@$(RM) bin/README.md


check-bazel: bin/bazel
ifndef BAZEL
$(eval BAZEL := bin/bazel)
Expand Down
16 changes: 8 additions & 8 deletions spec/02-integration/05-proxy/21-grpc_plugins_triggering_spec.lua
Original file line number Diff line number Diff line change
Expand Up @@ -101,22 +101,22 @@ local phrases_ssl = {
local phrases_reflection = {
["%[logger%] init_worker phase"] = 1,
["%[logger%] configure phase"] = 1,
["%[logger%] rewrite phase"] = 2,
["%[logger%] access phase"] = 2,
["%[logger%] header_filter phase"] = 2,
["%[logger%] rewrite phase"] = 3,
["%[logger%] access phase"] = 3,
["%[logger%] header_filter phase"] = 3,
["%[logger%] body_filter phase"] = -1,
["%[logger%] log phase"] = 2,
["%[logger%] log phase"] = 3,
}

local phrases_ssl_reflection = {
["%[logger%] init_worker phase"] = 1,
["%[logger%] configure phase"] = 1,
["%[logger%] certificate phase"] = 1,
["%[logger%] rewrite phase"] = 2,
["%[logger%] access phase"] = 2,
["%[logger%] header_filter phase"] = 2,
["%[logger%] rewrite phase"] = 3,
["%[logger%] access phase"] = 3,
["%[logger%] header_filter phase"] = 3,
["%[logger%] body_filter phase"] = -1,
["%[logger%] log phase"] = 2,
["%[logger%] log phase"] = 3,
}

local function assert_phases(phrases)
Expand Down
5 changes: 4 additions & 1 deletion spec/03-plugins/23-rate-limiting/04-access_spec.lua
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,10 @@ if limit_by == "ip" then
},
}
assert.falsy(ok)
assert.matches("Code: ResourceExhausted", res)

-- Kong should return "ResourceExhausted", but for some reason here,
-- perhaps because of grpcurl, it gets translated to "Unavailable".
assert.matches("Code: Unavailable", res)

assert.matches("ratelimit%-limit: 6", res)
assert.matches("ratelimit%-remaining: 0", res)
Expand Down
2 changes: 1 addition & 1 deletion spec/helpers.lua
Original file line number Diff line number Diff line change
Expand Up @@ -1061,7 +1061,7 @@ local function gen_grpcurl_opts(opts_t)

for opt, val in pairs(opts_t) do
if val ~= false then
opts_l[#opts_l + 1] = opt .. " " .. (type(val) == "string" and val or "")
opts_l[#opts_l + 1] = opt .. (type(val) == "string" and (" " .. val) or "")
end
end

Expand Down