Feat/o2k improvements #3396
Merged
Feat/o2k improvements #3396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitropoulos
force-pushed
the
feat/o2k-improvements
branch
from
8a428d4
to
33643d2
Compare
dimitropoulos
force-pushed
the
feat/o2k-improvements
branch
from
33643d2
to
bb4adb6
Compare
for better or for worse, until we upgrade `YAML` (it's now written in TypeScript) we should probably aim for consistency.
it would be FAR preferable to use an object with the arguments instead because then we don't have to fall into all the traps that come with overloads, but I am avoiding changing the actual call signature of these function.
we had everything in place for the rest of the build pipeline to consume these types, but were missing the main exports at the root index.ts file
evidently, this data is useful for the usage of o2k, therefore o2k should be the thing exporting it.
when first naming this, I didn't have much more context than the property name (documents), so after taking a look, it's clear that these are kubernetes manifests
I will return to this, and so I'm leaving it here in a commit rather than squashing it out, but I can't see a way to get it to work without changing the signature in a big way.
part of the motivation for this is that there are significant things in common between the two kinds of configs, making them closer in form is therefore ideal.
dimitropoulos
force-pushed
the
feat/o2k-improvements
branch
from
bb4adb6
to
b2ee435
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent PR (#3340) on inso went through a lot of iterations to try and find a suitable solution to the problem, and during that time there were some small things fixed along the way. I pulled those things out of the work on that PR and collected them here in the interest of cleanliness (but also because it looks like that PR may not merge super soon).
Best to read commit by commit, I tried to keep it very clean and document any changes where necessary.