Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add filter chains to Admin OSS spec #7387

Merged
merged 2 commits into from
May 16, 2024
Merged

feat: add filter chains to Admin OSS spec #7387

merged 2 commits into from
May 16, 2024

Conversation

hishamhm
Copy link
Contributor

@hishamhm hishamhm commented May 15, 2024

Description

Added WebAssembly Filter Chain endpoints to OSS Admin API spec, matching those from Admin-EE docs. (see #6829).

Testing instructions

Preview link:

Checklist

@hishamhm hishamhm added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label May 15, 2024
@hishamhm hishamhm requested a review from a team as a code owner May 15, 2024 18:47
Copy link

netlify bot commented May 15, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit b2fe69f
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/66461fc047256b0008b7ac5e
😎 Deploy Preview https://deploy-preview-7387--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 94 (🟢 up 4 from production)
Accessibility: 93 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Guaris Guaris self-assigned this May 15, 2024
@hishamhm
Copy link
Contributor Author

Even though I added the same entries from Admin-EE into api-specs/Gateway-OSS/latest/kong-oss.yaml, the Filter Chains docs did not show up in the Netlify preview: https://deploy-preview-7387--kongdocs.netlify.app/gateway/api/admin-oss/latest/#/filter-chains/get-filter-chains

Am I missing something? 🤔

@Guaris
Copy link
Contributor

Guaris commented May 15, 2024

Even though I added the same entries from Admin-EE into api-specs/Gateway-OSS/latest/kong-oss.yaml, the Filter Chains docs did not show up in the Netlify preview: https://deploy-preview-7387--kongdocs.netlify.app/gateway/api/admin-oss/latest/#/filter-chains/get-filter-chains

Am I missing something? 🤔

Yes, the specs have to be uploaded as API product documentation to the org's konnect organization.

@hishamhm
Copy link
Contributor Author

Yes, the specs have to be uploaded as API product documentation to the org's konnect organization.

@Guaris ah, thanks for the clarification! I don't think I have access to that. Is this something the docs-maintainers handle after this is reviewed and merged?

@Guaris
Copy link
Contributor

Guaris commented May 15, 2024

Yes, the specs have to be uploaded as API product documentation to the org's konnect organization.

@Guaris ah, thanks for the clarification! I don't think I have access to that. Is this something the docs-maintainers handle after this is reviewed and merged?

Absolutely!

Guaris
Guaris previously approved these changes May 16, 2024
@Guaris Guaris self-requested a review May 16, 2024 14:56
@Guaris Guaris dismissed their stale review May 16, 2024 14:56

misclick

@Guaris
Copy link
Contributor

Guaris commented May 16, 2024

LGTM
https://docs.konghq.com/gateway/api/admin-oss/latest/#/filter-chains/get-filter-chains

@Guaris Guaris merged commit 6698c27 into main May 16, 2024
15 checks passed
@Guaris Guaris deleted the filter-chains-OSS branch May 16, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants