-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: AI Azure Content Safety plugin doc #7326
Conversation
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@ttyS0e could you please review this doc for the new plugin and see if there's anything that could be added? I just based it on your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have completed this up to what the plugin can do right now.
3cc60a1
to
78f9182
Compare
78f9182
to
4c1238d
Compare
There's an issue with the way that arrays of records are being rendered in the output right now, I'm asking Fabian to help out. If we can't fix it quickly, I'll just revert the examples to plain yaml. |
TODO: we'll need to do the same with konnect
You may also be interested in the following AI plugins: | ||
* [AI Proxy](/hub/kong-inc/ai-proxy/) | ||
* [AI Request Transformer](/hub/kong-inc/ai-request-transformer/) | ||
* [AI Response Transformer](/hub/kong-inc/ai-request-transformer/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* [AI Response Transformer](/hub/kong-inc/ai-request-transformer/) | |
* [AI Response Transformer](/hub/kong-inc/ai-request-transformer/) | |
{% if_version gte:3.7.x %} | |
* [AI Rate Limiting Advanced](/hub/kong-inc/ai-rate-limiting-advanced/) | |
{% endif_version %} |
This one was added to AI Proxy's homepage, I wonder if this Other AI plugins section should be an include since it's used on all the AI plugin overview pages. It would be easier to maintain that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. We could just rename it to "All AI plugins" or just "AI plugins" and put them in an include, like you said. Right now the list is different for each plugin since it doesn't contain a link to the plugin you're already on. But I don't think it's a big deal to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to do this separately, outside of this plugin's PR. This PR is already getting overloaded with extra/not the most related content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few small comments!
|
||
## Authentication | ||
|
||
In each instance of the plugin, it supports one of: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean you have to pick either content safety key or managed identity auth? Or that you can have one key as well as one managed identity auth at the same time?
Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
b092427
to
dd453d3
Compare
Description
Docs for new AI Azure Content Safety plugin.
https://konghq.atlassian.net/browse/DOCU-3767
Testing instructions
Preview link: https://deploy-preview-7326--kongdocs.netlify.app/hub/kong-inc/ai-azure-content-safety/unreleased/
Checklist