Feat/format version 3.0 #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbagdi
reviewed
Sep 14, 2022
GGabriele
force-pushed
the
feat/format-version-3.0-test
branch
from
db7331b
to
a139df4
Compare
Codecov Report
@@ Coverage Diff @@
## main #753 +/- ##
==========================================
- Coverage 39.98% 39.81% -0.18%
==========================================
Files 87 87
Lines 9715 9834 +119
==========================================
+ Hits 3885 3915 +30
- Misses 5459 5543 +84
- Partials 371 376 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
GGabriele
force-pushed
the
feat/format-version-3.0-test
branch
from
b0c808d
to
9ac13e4
Compare
GGabriele
force-pushed
the
feat/format-version-3.0-test
branch
from
9ac13e4
to
28bd040
Compare
GGabriele
force-pushed
the
feat/format-version-3.0-test
branch
from
28bd040
to
e385db0
Compare
GGabriele
force-pushed
the
feat/format-version-3.0-test
branch
from
e385db0
to
8dff2bd
Compare
omegabytes
reviewed
Sep 20, 2022
mikefero
reviewed
Sep 20, 2022
GGabriele
force-pushed
the
feat/format-version-3.0-test
branch
from
de6168c
to
68bed9d
Compare
GGabriele
force-pushed
the
feat/format-version-3.0-test
branch
from
68bed9d
to
fa28485
Compare
GGabriele
force-pushed
the
feat/format-version-3.0-test
branch
from
abcdf77
to
0595083
Compare
hbagdi
reviewed
Sep 23, 2022
hbagdi
reviewed
Sep 23, 2022
hbagdi
reviewed
Sep 23, 2022
hbagdi
reviewed
Sep 23, 2022
Before this change, the "1.1" format version was hardcoded when `deck dump` was ran. Now deck: - sets `_format_version: 1.1` with Kong < 3.x - sets `_format_version: 3.0` with Kong >= 3.x
GGabriele
force-pushed
the
feat/format-version-3.0-test
branch
from
0595083
to
cf4e8a0
Compare
GGabriele
force-pushed
the
feat/format-version-3.0-test
branch
from
cf4e8a0
to
38208a3
Compare
hbagdi
previously approved these changes
Sep 23, 2022
convert/convert.go
Outdated
| cprint.UpdatePrintf( | ||
| "From the '%s' config file,\n"+ | ||
| "%d unsupported routes' paths format with Kong version 3.0\n"+ | ||
| "or above were detected, including:\n\n"+ |
There was a problem hiding this comment.
Suggested change
| "or above were detected, including:\n\n"+ | |
| "or above were detected, Some of these routes are (not an exhaustive list):\n\n"+ |
utils/utils.go
Outdated
| } | ||
| cprint.UpdatePrintf( | ||
| "%d unsupported routes' paths format with Kong version 3.0\n"+ | ||
| "or above were detected, including:\n\n"+ |
GGabriele
force-pushed
the
feat/format-version-3.0-test
branch
from
38208a3
to
53d1f52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.