fix: correct order of precedence to gate Konnect mode #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now decK runs against Konnect if some Konnect credentials are around, either via command flags or via environment variables. In the case of having a `kong-addr` different from the default value and some lingering Konnect credentials environment variables set, decK would still decide to run against Konnect instead of Kong. This PR is reworking the order of precedence gating Konnect: 1. if the config file contains the `_konnect` entry, run against Konnect 2. if the `kong-addr` is set to a non-default value, run against Kong 3. if some Konnect credentials are set, run against Konnect 4. otherwise run against Kong
Codecov Report
@@ Coverage Diff @@
## main #738 +/- ##
==========================================
- Coverage 43.05% 43.04% -0.02%
==========================================
Files 74 74
Lines 9016 9019 +3
==========================================
Hits 3882 3882
- Misses 4763 4766 +3
Partials 371 371
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hbagdi
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now decK runs against Konnect if some Konnect
credentials are around, either via command flags or via
environment variables. In the case of having a
kong-addrdifferent from the default value and some lingering Konnect
credentials environment variables set, decK would still
decide to run against Konnect instead of Kong.
This PR is reworking the order of precedence gating Konnect:
_konnectentry, runagainst Konnect
kong-addris set to a non-default value, runagainst Kong