fix: make semverCompare handle GKE versions and release 2.16.1 #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
fix-projected-sa-gke
branch
from
407c500
to
fb2b9b1
Compare
czeslavo
force-pushed
the
fix-projected-sa-gke
branch
3 times, most recently
from
225d34e
to
3befff7
Compare
pmalek
previously approved these changes
Feb 6, 2023
czeslavo
force-pushed
the
fix-projected-sa-gke
branch
from
3befff7
to
5b2c19e
Compare
czeslavo
changed the title
pmalek
approved these changes
Feb 6, 2023
Nah, seems like charts are tested only against KinD, and in KIC we don't use the chart to install the controller (only proxy). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes
semverComparecall that decides whether to create a projected volumeMount for the service account. It didn't work on GKE where the expected version format isvX.Y.Z-gke.N. It was resulting in:deployment.yaml)secret-sa-token.yaml)which made deployment fail to become ready because of the missing secret to be mounted.
Regression was introduced in #722.
See related upstream issues:
Which issue this PR fixes
Fixes bug discovered in KTF CI run: https://github.com/Kong/kubernetes-testing-framework/actions/runs/4102865692/jobs/7076352608
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
mainbranch.[ ] New or modified sections of values.yaml are documented in the README.md