Return &mut str from encode_to_slice #72
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use this crate a lot, especially in
no_std
or performance-sensitive environments. and I useencode_to_slice
quite a lot, and usually, I need then to convert the slice into anstr
to pass to a serializer/formatter.I think it makes sense that
encode_to_slice
will return a&mut str
because it just checked all the invariants and can verify that in debug mode.Sadly this breaks the API in the rare case where the returned
()
was used, so bumped to 0.5.