Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev-dependencies #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update dev-dependencies #63

wants to merge 1 commit into from

Conversation

taiki-e
Copy link

@taiki-e taiki-e commented Jul 18, 2021

  • faster-hex 0.5 -> 0.6
  • pretty_assertions 0.6 -> 1.0

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2021

Codecov Report

Merging #63 (4f39df9) into main (aa8f300) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files           4        4           
  Lines         147      147           
=======================================
  Hits          139      139           
  Misses          8        8           
Impacted Files Coverage Δ
tests/version-number.rs 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa8f300...4f39df9. Read the comment docs.

@Luro02
Copy link
Contributor

Luro02 commented Aug 27, 2021

The new version of pretty-assertions seems to have caused a regression, which is not documented in the changelog. So it no longer compiles for crates, which have #![no_std] enabled.

@taiki-e
Copy link
Author

taiki-e commented Aug 28, 2021

The new version of pretty-assertions seems to have caused a regression, which is not documented in the changelog. So it no longer compiles for crates, which have #![no_std] enabled.

Well, pretty_assertions doesn't originally support no_std, so that wouldn't necessarily be considered a breaking change.

@Luro02
Copy link
Contributor

Luro02 commented Sep 29, 2021

@taiki-e this seems to be fixed with the latest release of pretty-assertions, see: https://github.com/colin-kiegel/rust-pretty-assertions/blob/main/CHANGELOG.md#added

@taiki-e taiki-e force-pushed the deps branch 2 times, most recently from cd9f38c to 4f39df9 Compare October 1, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants