Use const-generics to implement FromHex trait #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rust version 1.51 a small subset of const-generics has been stabilized, which removes the need for the previously used macro.
|
I really would love to use const-generics to replace these awful "magic-number thingy impls", but i think it would need some requirements, like a MSRV set for Also there's stuff i would like to try to make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rust version 1.51 a small subset of const-generics has been
stabilized, which removes the need for the previously used macro.
Because of the widespread use of this crate and previous issues with minor versions breaking the msrv of this crate, I would suggest making this PR part of the 0.5.0 release.