OTA update check: inform about uncommon version mismatch #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return -1/0/1 for version check
return -1/0/1 for version check
spot beta firmwares or version mismatch
kiall
reviewed
Feb 22, 2020
ota/common.js
Outdated
| return available; | ||
| logger.debug(`Update available for '${device.ieeeAddr}': ${available < 0 ? 'YES' : 'NO'}`); | ||
| if (available > 0) { | ||
| logger.debug(`Firmware on '${device.ieeeAddr}' is newer than latest firmware online.`); |
There was a problem hiding this comment.
This probably deserves to be a warning rather than debug level message?
|
Thanks! |
Koenkk
added a commit
to pedrolamas/zigbee-herdsman-converters
that referenced
this pull request
Feb 23, 2020
Koenkk
added a commit
that referenced
this pull request
Feb 23, 2020
* Output OTA debug information from Osram devices * Adds OTA update support for Osram/Ledvance devices * Improves image availability checks * Parse fullName element in metadata to retrieve fileVersion * Renames osram references to more accurate ledvance * Sync with #1005 Co-authored-by: Koen Kanters <koenkanters94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added debug message for cases where device firmware is newer than the latest version online. This should not happen but might be a helpful log message when version numbers were incorrectly interpreted or a manufacturer changed up the numbering scheme.
See #1000 (comment)