Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme to suggest the latest major version #816

Closed
wants to merge 1 commit into from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Oct 16, 2019

No description provided.

@staabm
Copy link
Contributor Author

staabm commented Oct 16, 2019

with my suggested change you run into:

Using version ^2.11 for knplabs/github-api
Using version ^2.0 for php-http/guzzle6-adapter
./composer.json has been created
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - knplabs/github-api 2.11.0 requires php-http/client-implementation ^1.0 -> satisfiable by php-http/guzzle6-adapter[v2.0.0, v2.0.1].
    - php-http/guzzle6-adapter v2.0.0 requires php-http/httplug ^2.0 -> satisfiable by php-http/httplug[v2.0.0].
    - php-http/guzzle6-adapter v2.0.1 requires php-http/httplug ^2.0 -> satisfiable by php-http/httplug[v2.0.0].
    - Can only install one of: php-http/httplug[v2.0.0, v1.1.0].
    - knplabs/github-api 2.11.0 requires php-http/httplug ^1.1 -> satisfiable by php-http/httplug[v1.1.0].
    - Installation request for knplabs/github-api ^2.11 -> satisfiable by knplabs/github-api[2.11.0].


Installation failed, deleting ./composer.json.

.. I guess I am wrong

@staabm staabm closed this Oct 16, 2019
@staabm staabm deleted the patch-1 branch October 16, 2019 13:52
@acrobat
Copy link
Collaborator

acrobat commented Oct 17, 2019

@staabm yes indeed, this library is not yet compatible with httplug 2. We are looking into ways to support both versions. See #802

@staabm
Copy link
Contributor Author

staabm commented Oct 17, 2019

thx for the feedback.

I was mainly confused by the notation, because I read it like
composer require knplabs/github-api php-http/guzzle6-adapter "^1.1" would install the github-api class in version 1.1 but it installs the latest github-api and the ^1.1 only refers to the version of the guzzle adapter.

haven't seen this kind of notation anywhere else before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants