Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Code completion #1113

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

haridarshan
Copy link
Contributor

Feature:

  • PhpStorm improve code completion

Closes #1092

Signed-off-by: Hari Darshan Gorana <er.haridarshan@gmail.com>
@haridarshan haridarshan marked this pull request as ready for review April 24, 2023 10:39
@acrobat
Copy link
Collaborator

acrobat commented May 13, 2023

@haridarshan thanks for the PR! I'm thinking if we could have a script to generate this file based on the current code, this way we can generate it on each release and users contributing to this package don't need to add the new endpoints to mulitple files. This would avoid releasing new versions with outdated meta files

What do you think?

@haridarshan
Copy link
Contributor Author

@acrobat I think that will be much better instead of manually updating this file. I will try to work on creating the script for the same.

Signed-off-by: Hari Darshan Gorana <er.haridarshan@gmail.com>
@haridarshan
Copy link
Contributor Author

haridarshan commented May 22, 2023

@acrobat Please go through the script once and let me know the changes. Once finalized, we can set GHA to run this script and auto-generate/update .phpstorm.meta.php file

Signed-off-by: Hari Darshan Gorana <er.haridarshan@gmail.com>
…r` dep

Signed-off-by: Hari Darshan Gorana <er.haridarshan@gmail.com>
Copy link
Contributor

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel like these changes belong here.

@acrobat
Copy link
Collaborator

acrobat commented May 22, 2023

What do you mean @GrahamCampbell? Any specifics or the whole PR?

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .phpstorm.meta.php to improve code completion
4 participants