minor #1125 General chores (acrobat)

This PR was merged into the 3.12-dev branch. Discussion ---------- Commits ------- 14e8eed Switch roave bc-checker from docker to local setup 10080cd Apply style-ci fixes
KnpLabs · Oct 17, 2023 · 90360bc · 90360bc
2 parents 113f6b3 + 10080cd
commit 90360bc
Show file tree

Hide file tree

Showing 9 changed files with 22 additions and 4 deletions.
diff --git a/.github/workflows/backwards-compatibility.yml b/.github/workflows/backwards-compatibility.yml
@@ -12,7 +12,13 @@ jobs:
                 with:
                     fetch-depth: 0
 
-            -   name: Roave BC Check
-                uses: docker://nyholm/roave-bc-check-ga
+            -   name: Install PHP
+                uses: shivammathur/setup-php@v2
                 with:
-                    args: --from=${{ github.event.pull_request.base.sha }}
+                    php-version: '8.2'
+
+            -   name: Install roave/backward-compatibility-check
+                run: composer require --dev roave/backward-compatibility-check
+
+            -   name: Run roave/backward-compatibility-check
+                run: vendor/bin/roave-backward-compatibility-check --from=${{ github.event.pull_request.base.sha }} --format=github-actions
diff --git a/lib/Github/Api/CurrentUser/Watchers.php b/lib/Github/Api/CurrentUser/Watchers.php
@@ -8,6 +8,7 @@
  * @link   https://developer.github.com/v3/activity/watching/
  *
  * @author Joseph Bielawski <stloyd@gmail.com>
+ *
  * @revised Felipe Valtl de Mello <eu@felipe.im>
  */
 class Watchers extends AbstractApi

diff --git a/lib/Github/HttpClient/Plugin/GithubExceptionThrower.php b/lib/Github/HttpClient/Plugin/GithubExceptionThrower.php
@@ -88,7 +88,6 @@ public function handleRequest(RequestInterface $request, callable $next, callabl
                                     $errors[] = $error['message'];
                                 }
                                 break;
-
                         }
                     }
 

diff --git a/test/Github/Tests/Api/Enterprise/StatsTest.php b/test/Github/Tests/Api/Enterprise/StatsTest.php
@@ -24,6 +24,7 @@ public function shouldShowStats()
 
     /**
      * @test
+     *
      * @dataProvider getTypes
      */
     public function shouldShowStatsByType($type)

diff --git a/test/Github/Tests/Api/Repository/AssetsTest.php b/test/Github/Tests/Api/Repository/AssetsTest.php
@@ -43,6 +43,7 @@ public function shouldGetSingleReleaseAsset()
 
     /**
      * @test
+     *
      * @requires PHP 5.3.4
      */
     public function shouldCreateReleaseAsset()

diff --git a/test/Github/Tests/Api/Repository/ContentsTest.php b/test/Github/Tests/Api/Repository/ContentsTest.php
@@ -71,6 +71,7 @@ public function getFailureStubsForExistsTest()
      * @param \PHPUnit_Framework_MockObject_Stub|\PHPUnit\Framework\MockObject\Stub\Exception
      *
      * @test
+     *
      * @dataProvider getFailureStubsForExistsTest
      */
     public function shouldReturnFalseWhenFileIsNotFound($failureStub)

diff --git a/test/Github/Tests/ClientTest.php b/test/Github/Tests/ClientTest.php
@@ -40,6 +40,7 @@ public function shouldPassHttpClientInterfaceToConstructor()
 
     /**
      * @test
+     *
      * @dataProvider getAuthenticationFullData
      */
     public function shouldAuthenticateUsingAllGivenParameters($login, $password, $method)
@@ -115,6 +116,7 @@ public function shouldThrowExceptionWhenAuthenticatingWithoutMethodSet()
 
     /**
      * @test
+     *
      * @dataProvider getApiClassesProvider
      */
     public function shouldGetApiInstance($apiName, $class)
@@ -126,6 +128,7 @@ public function shouldGetApiInstance($apiName, $class)
 
     /**
      * @test
+     *
      * @dataProvider getApiClassesProvider
      */
     public function shouldGetMagicApiInstance($apiName, $class)

diff --git a/test/Github/Tests/Integration/IssueCommentTest.php b/test/Github/Tests/Integration/IssueCommentTest.php
@@ -31,6 +31,7 @@ public function shouldRetrieveCommentsForIssue()
 
     /**
      * @test
+     *
      * @depends shouldRetrieveCommentsForIssue
      */
     public function shouldRetrieveSingleComment($commentId)
@@ -72,6 +73,7 @@ public function shouldCreateCommentForIssue()
 
     /**
      * @test
+     *
      * @depends shouldCreateCommentForIssue
      */
     public function shouldUpdateCommentByCommentId($commentId)
@@ -94,6 +96,7 @@ public function shouldUpdateCommentByCommentId($commentId)
 
     /**
      * @test
+     *
      * @depends shouldUpdateCommentByCommentId
      */
     public function shouldRemoveCommentByCommentId($commentId)

diff --git a/test/Github/Tests/Integration/RepoCommentTest.php b/test/Github/Tests/Integration/RepoCommentTest.php
@@ -70,6 +70,7 @@ public function shouldCreateCommentForCommit()
 
     /**
      * @test
+     *
      * @depends shouldCreateCommentForCommit
      */
     public function shouldShowCommentByCommentId($commentId)
@@ -91,6 +92,7 @@ public function shouldShowCommentByCommentId($commentId)
 
     /**
      * @test
+     *
      * @depends shouldShowCommentByCommentId
      */
     public function shouldUpdateCommentByCommentId($commentId)
@@ -113,6 +115,7 @@ public function shouldUpdateCommentByCommentId($commentId)
 
     /**
      * @test
+     *
      * @depends shouldUpdateCommentByCommentId
      */
     public function shouldRemoveCommentByCommentId($commentId)