Merge pull request #833 from GrahamCampbell/fix-validation-errors

Fixed handling of validation errors
KnpLabs · Nov 6, 2019 · 1ed6cac · 1ed6cac
2 parents d281e29 + 1a42250
commit 1ed6cac
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/lib/Github/HttpClient/Plugin/GithubExceptionThrower.php b/lib/Github/HttpClient/Plugin/GithubExceptionThrower.php
@@ -76,13 +76,18 @@ public function doHandleRequest(RequestInterface $request, callable $next, calla
                                 break;
 
                             default:
-                                $errors[] = $error['message'];
+                                if (isset($error['message'])) {
+                                    $errors[] = $error['message'];
+                                }
                                 break;
 
                         }
                     }
 
-                    throw new ValidationFailedException('Validation Failed: '.implode(', ', $errors), 422);
+                    throw new ValidationFailedException(
+                        $errors ? 'Validation Failed: '.implode(', ', $errors) : 'Validation Failed',
+                        422
+                    );
                 }
             }